Re: [PATCH] gdb: Respect CXXFLAGS when building with C++ compiler

Pedro Alves
2016-01-21T11:37:08Z

On 01/20/2016 10:52 PM, Simon Marchi wrote:
> On 16-01-20 03:40 PM, Pedro Alves wrote:
>> Yeah, it crossed my mind too, but then all others end up _CFLAGS,
>> like INTERNAL_CFLAGS, GLOBAL_CFLAGS, GDB_WERROR_CFLAGS,
>> INTERNAL_WARN_CFLAGS, etc., which are used in c++ too,
>> that I thought it ended up looking the odd one out. WDYT?
>
> Then you can change the others too :)
>
> INTERNAL_CFLAGS -> INTERNAL_COMPILER_FLAGS
> GLOBAL_CFLAGS -> GLOBAL_COMPILER_FLAGS
> GDB_WERROR_CFLAGS -> GDB_WERROR_COMPILER_FLAGS
> etc...
>
> But it's a minor detail and probably temporary too, so I'm fine
> with COMPILER_CFLAGS.

Yeah, I'd rather not change everything. Maybe we'll rename all
those to INTERNAL_CXXFLAGS, etc. soon enough. :-)

I've pushed the patch in now.

Thanks,
Pedro Alves