From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54171 invoked by alias); 20 Jan 2016 18:20:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54154 invoked by uid 89); 20 Jan 2016 18:20:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:string_ X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Jan 2016 18:20:24 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 670AC39CA6F; Wed, 20 Jan 2016 18:20:23 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0KIKMJQ019881; Wed, 20 Jan 2016 13:20:22 -0500 Message-ID: <569FCFE6.8020002@redhat.com> Date: Wed, 20 Jan 2016 18:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix sorting of enum values in FlagEnumerationPrinter References: <1453313447-21194-1-git-send-email-simon.marchi@polymtl.ca> In-Reply-To: <1453313447-21194-1-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00487.txt.bz2 On 01/20/2016 06:10 PM, Simon Marchi wrote: > I noticed that I could change the regexps to almost anything and the > tests would still pass. I think it was because of the | in there. I > made them more robust by using string_to_regexp. You can use gdb_test_exact instead, which does the string_to_regexp for you. OK with that change. Thanks, Pedro Alves