From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73205 invoked by alias); 19 Jan 2016 11:24:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73190 invoked by uid 89); 19 Jan 2016 11:24:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=if, perf, Hx-languages-length:1766 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Jan 2016 11:24:44 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 203C98F4FB; Tue, 19 Jan 2016 11:24:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0JBOfcU027074; Tue, 19 Jan 2016 06:24:42 -0500 Message-ID: <569E1CF9.5010102@redhat.com> Date: Tue, 19 Jan 2016 11:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: Add --status to runtest invocation References: <1453157560-7080-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1453157560-7080-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00420.txt.bz2 On 01/18/2016 10:52 PM, Simon Marchi wrote: > As discussed in this thread: > > https://sourceware.org/ml/gdb-patches/2016-01/msg00243.html > > By default, if a test driver (a test .exp) ends with an uncaught > error/exception, the runtest command will still have a return code of 0 > (success). I think that if a test (or the environment) is broken and > the test ends up with an exception, it should be considered as failed so > that we can notice it and fix it. > > Passing the --status flag to runtest will make it return an error if one > of the test it runs ends up with an uncaught error. > > gdb/testsuite/ChangeLog: > > * Makefile.in (check-single): Pass --status to runtest. > (check/%.exp): Likewise. Hmm, the perf bits of the runtest invocation already pass --status: @GMAKE_TRUE@ $(DO_RUNTEST) --status --outdir=gdb.perf/outputs/$* lib/build-piece.exp WORKER=$* GDB_PARALLEL=gdb.perf $(RUNTESTFLAGS) GDB_PERFTEST_MODE=compile GDB_PERFTEST_SUBMODE=build-pieces ... @GMAKE_TRUE@ $(DO_RUNTEST) --status --directory=gdb.perf --outdir gdb.perf/workers GDB_PARALLEL=gdb.perf $(RUNTESTFLAGS) GDB_PERFTEST_MODE=compile GDB_PERFTEST_SUBMODE=gen-workers ... @GMAKE_TRUE@ $(DO_RUNTEST) --status --directory=gdb.perf --outdir gdb.perf GDB_PARALLEL=gdb.perf $(RUNTESTFLAGS) GDB_PERFTEST_MODE=compile GDB_PERFTEST_SUBMODE=final But there's one that doesn't: check-perf: all $(abs_builddir)/site.exp @if test ! -d gdb.perf; then mkdir gdb.perf; fi $(DO_RUNTEST) --directory=gdb.perf --outdir gdb.perf GDB_PERFTEST_MODE=$(GDB_PERFTEST_MODE) $(RUNTESTFLAGS) Seems like an oversight? How about adding --status to DO_RUNTEST directly instead, so that all invocations are always covered? Thanks, Pedro Alves