From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-128792-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 46950 invoked by alias); 19 Jan 2016 10:39:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 46935 invoked by uid 89); 19 Jan 2016 10:39:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Jan 2016 10:39:22 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (Postfix) with ESMTPS id 23ADF8E243;	Tue, 19 Jan 2016 10:39:21 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0JAdKI6003958;	Tue, 19 Jan 2016 05:39:20 -0500
Message-ID: <569E1257.4040805@redhat.com>
Date: Tue, 19 Jan 2016 10:39:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 4/7] Display per-thread information for threads in FreeBSD cores.
References: <1453142254-20266-1-git-send-email-jhb@FreeBSD.org> <1453142254-20266-5-git-send-email-jhb@FreeBSD.org>
In-Reply-To: <1453142254-20266-5-git-send-email-jhb@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-01/txt/msg00413.txt.bz2

This is OK.

On 01/18/2016 06:37 PM, John Baldwin wrote:

> +	      /* Note that each thread will report the process command
> +		 as its thread name instead of an empty name if a name
> +		 has not been set explicitly.  Return a NULL name in
> +		 that case.  */
> +	      if (strcmp (buf, elf_tdata (core_bfd)->core->program) != 0)
> +		  return buf;

(Not sure, but I think the alignment of that return is odd.)

Thanks,
Pedro Alves