From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23325 invoked by alias); 18 Jan 2016 21:29:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23158 invoked by uid 89); 18 Jan 2016 21:29:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Wow, Hx-languages-length:665, cool! X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 18 Jan 2016 21:29:02 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 5E1BFA37CE; Mon, 18 Jan 2016 21:29:01 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0ILT0eh007752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 18 Jan 2016 16:29:00 -0500 Subject: Re: [RFA] Fix regression introduced in "break *" by explicit location patches To: Joel Brobecker References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> <20150805232951.21646.67733.stgit@valrhona.uglyboxes.com> <20151214071113.GA6230@adacore.com> <566F2CF1.1030003@redhat.com> <20151215133948.GA7938@adacore.com> <20160117153229.GF4059@adacore.com> Cc: gdb-patches@sourceware.org From: Keith Seitz Message-ID: <569D591C.5000509@redhat.com> Date: Mon, 18 Jan 2016 21:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160117153229.GF4059@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00403.txt.bz2 On 01/17/2016 07:32 AM, Joel Brobecker wrote: > What do you think of the attached patch? There is also a testcase, > which is slightly different from the scenario that triggered this > exchange, but which also has the advantage of not requiring PIE, > which makes the test a little more universal, I think. This looks great to me. I say go for it. [Wow, you found a non-PIE reproducer. Way cool!] Keith PS. I also note there was a "save breakpoints" bug related to this bug, too. I'll work on a separate submission for that. This is definitely should have some test coverage!