From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22020 invoked by alias); 15 Jan 2016 21:41:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22008 invoked by uid 89); 15 Jan 2016 21:41:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=get_ptrace_pid, openbsd, OpenBSD, Hx-languages-length:925 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 15 Jan 2016 21:41:22 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E25D28DFEB; Fri, 15 Jan 2016 21:41:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0FLfJSS007457; Fri, 15 Jan 2016 16:41:20 -0500 Message-ID: <5699677F.3040808@redhat.com> Date: Fri, 15 Jan 2016 21:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: John Baldwin CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/6] Use LWP IDs with ptrace register requests on FreeBSD. References: <1452721551-657-1-git-send-email-jhb@FreeBSD.org> <1452721551-657-5-git-send-email-jhb@FreeBSD.org> <5697B9B0.1090705@redhat.com> <6071650.bM8jrAlx9r@ralph.baldwin.cx> In-Reply-To: <6071650.bM8jrAlx9r@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00334.txt.bz2 On 01/15/2016 08:18 PM, John Baldwin wrote: > On Thursday, January 14, 2016 03:07:28 PM Pedro Alves wrote: >> [Dropping binutils.] >> >> On 01/13/2016 09:45 PM, John Baldwin wrote: >>> This allows gdb to fetch per-thread registers for multi-threaded FreeBSD >>> processes. NetBSD and OpenBSD also accept LWP IDs for ptrace requests >>> to fetch per-thread state. >> >> I'd prefer to make inf-ptrace.c:get_ptrace_pid extern and use >> it, instead of duplicating it multiple times. > > This sounds good to me. Do you want me to use it in other places as well? > sparc-nat.c at least duplicates the same logic inline. amd64linux-nat.c > does as well. If so, would you rather that be a seperate patch (expose > get_ptrace_pid() and use it in existing targets) from this patch? I won't impose that as requirement, but that'd be nice. Thanks, Pedro Alves