Re: [PATCH 2/2] Star wildcard ranges (e.g., "info thread 2.*")

Pedro Alves
2016-01-14T11:13:52Z

On 01/13/2016 05:00 PM, Eli Zaretskii wrote:
>> From: Pedro Alves <palves@redhat.com>
>> Date: Wed, 13 Jan 2016 16:34:45 +0000
>>
>> Add support for specifying "all threads of inferior N", by writing "*"
>> as thread number/range in thread ID lists.
>>
>> E.g., "info threads 2.*" or "thread apply 2.* bt".
>
> Thanks.
>
>> +* In commands that accept thread IDs lists, you can now refer to all
>
> "thread ID lists", only one word in plural. Or maybe even better:
> "lists of thread IDs".

Hmm, going further, I think that "list" should be singular too:

In commands that accept a thread ID list, you can now refer to all
In commands that accept a list of thread IDs, you can now refer to all

I prefer the former because "thread ID list" is a defined term in
the manual.

>
>> +argument. A list element can be:
>> +
>> +@enumerate
>> +@item
>> +a thread ID as shown in the first field of the @samp{info threads}
>> +display, with or without an inferior qualifier. E.g., @samp{2.1} or
>> +@samp{1}.
>> +
>> +@item
>> +a range of thread numbers, again with or without an inferior
>> +qualifier, as in @var{inf}.@var{thr1}-@var{thr2} or
>> +@var{thr1}-@var{thr2}. E.g., @samp{1.2-4} or @samp{2-4}.
>> +
>> +@item
>> +all threads of an inferior, specified with a star wildcard, with or
>> +without an inferior qualifier, as in @var{inf}.@code{*} (e.g.,
>> +@samp{1.*}) or @code{*}. The former refers to all threads of the
>> +given inferior, and the latter form without an inferior qualifier
>> +refers to all threads of the current inferior.
>
> In this enumeration, each item begins with a lower-case letter, and
> then continues with another sentence. I suggest to capitalize the
> first letter of each item, to be more grammatically correct.
>
> Otherwise, the documentation parts are OK.

Thanks. Here's the diff that I'm squashing in with the original version.

diff --git a/gdb/NEWS b/gdb/NEWS
index c00dac9..be3536c 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -34,7 +34,7 @@
[Switching to thread 2.1 (Thread 0x7ffff7fc2740 (LWP 8157))] (running)
(gdb)

-* In commands that accept thread IDs lists, you can now refer to all
+* In commands that accept a thread ID list, you can now refer to all
threads of an inferior using a star wildcard. GDB accepts
"INF_NUM.*", to refer to all threads of inferior INF_NUM, and "*" to
refer to all threads of the current inferior. For example, "info

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index fbc76fa..a08a196 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -2916,17 +2916,17 @@ argument. A list element can be:

@enumerate
@item
-a thread ID as shown in the first field of the @samp{info threads}
+A thread ID as shown in the first field of the @samp{info threads}
display, with or without an inferior qualifier. E.g., @samp{2.1} or
@samp{1}.

@item
-a range of thread numbers, again with or without an inferior
+A range of thread numbers, again with or without an inferior
qualifier, as in @var{inf}.@var{thr1}-@var{thr2} or
@var{thr1}-@var{thr2}. E.g., @samp{1.2-4} or @samp{2-4}.

@item
-all threads of an inferior, specified with a star wildcard, with or
+All threads of an inferior, specified with a star wildcard, with or
without an inferior qualifier, as in @var{inf}.@code{*} (e.g.,
@samp{1.*}) or @code{*}. The former refers to all threads of the
given inferior, and the latter form without an inferior qualifier
--
1.9.3