From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [ARM] Remove field syscall_next_pc in struct gdbarch_tdep
Date: Thu, 14 Jan 2016 13:57:00 -0000 [thread overview]
Message-ID: <5697A94B.5080002@ericsson.com> (raw)
In-Reply-To: <861t9kuviv.fsf@gmail.com>
On 01/14/2016 08:43 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> Maybe it's only in the email ? but it seems like it's
>>
>> static CORE_ADDR
>> arm_linux_get_next_pcs_syscall_next_pc (struct arm_get_next_pcs *self,
>>
>> When it should be :
>>
>> static CORE_ADDR
>> arm_linux_get_next_pcs_syscall_next_pc (struct arm_get_next_pcs *self,
>
> No, it is intended. We don't write declaration at column zero. See
> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
>
Right by bad, thanks,
Antoine
next prev parent reply other threads:[~2016-01-14 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 16:53 Yao Qi
2016-01-13 19:20 ` Antoine Tremblay
2016-01-14 9:56 ` Yao Qi
2016-01-14 13:07 ` Antoine Tremblay
2016-01-14 13:43 ` Yao Qi
2016-01-14 13:57 ` Antoine Tremblay [this message]
2016-01-14 14:57 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5697A94B.5080002@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox