From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13014 invoked by alias); 14 Jan 2016 11:13:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12995 invoked by uid 89); 14 Jan 2016 11:13:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=34,7, letter, news X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 Jan 2016 11:13:49 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id B6547C09FAA5; Thu, 14 Jan 2016 11:13:48 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0EBDlZn015713; Thu, 14 Jan 2016 06:13:47 -0500 Message-ID: <569782EB.2030509@redhat.com> Date: Thu, 14 Jan 2016 11:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Star wildcard ranges (e.g., "info thread 2.*") References: <1452702886-17749-1-git-send-email-palves@redhat.com> <1452702886-17749-3-git-send-email-palves@redhat.com> <83k2ndifd4.fsf@gnu.org> In-Reply-To: <83k2ndifd4.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00289.txt.bz2 On 01/13/2016 05:00 PM, Eli Zaretskii wrote: >> From: Pedro Alves >> Date: Wed, 13 Jan 2016 16:34:45 +0000 >> >> Add support for specifying "all threads of inferior N", by writing "*" >> as thread number/range in thread ID lists. >> >> E.g., "info threads 2.*" or "thread apply 2.* bt". > > Thanks. > >> +* In commands that accept thread IDs lists, you can now refer to all > > "thread ID lists", only one word in plural. Or maybe even better: > "lists of thread IDs". Hmm, going further, I think that "list" should be singular too: In commands that accept a thread ID list, you can now refer to all In commands that accept a list of thread IDs, you can now refer to all I prefer the former because "thread ID list" is a defined term in the manual. > >> +argument. A list element can be: >> + >> +@enumerate >> +@item >> +a thread ID as shown in the first field of the @samp{info threads} >> +display, with or without an inferior qualifier. E.g., @samp{2.1} or >> +@samp{1}. >> + >> +@item >> +a range of thread numbers, again with or without an inferior >> +qualifier, as in @var{inf}.@var{thr1}-@var{thr2} or >> +@var{thr1}-@var{thr2}. E.g., @samp{1.2-4} or @samp{2-4}. >> + >> +@item >> +all threads of an inferior, specified with a star wildcard, with or >> +without an inferior qualifier, as in @var{inf}.@code{*} (e.g., >> +@samp{1.*}) or @code{*}. The former refers to all threads of the >> +given inferior, and the latter form without an inferior qualifier >> +refers to all threads of the current inferior. > > In this enumeration, each item begins with a lower-case letter, and > then continues with another sentence. I suggest to capitalize the > first letter of each item, to be more grammatically correct. > > Otherwise, the documentation parts are OK. Thanks. Here's the diff that I'm squashing in with the original version. diff --git a/gdb/NEWS b/gdb/NEWS index c00dac9..be3536c 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -34,7 +34,7 @@ [Switching to thread 2.1 (Thread 0x7ffff7fc2740 (LWP 8157))] (running) (gdb) -* In commands that accept thread IDs lists, you can now refer to all +* In commands that accept a thread ID list, you can now refer to all threads of an inferior using a star wildcard. GDB accepts "INF_NUM.*", to refer to all threads of inferior INF_NUM, and "*" to refer to all threads of the current inferior. For example, "info diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index fbc76fa..a08a196 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -2916,17 +2916,17 @@ argument. A list element can be: @enumerate @item -a thread ID as shown in the first field of the @samp{info threads} +A thread ID as shown in the first field of the @samp{info threads} display, with or without an inferior qualifier. E.g., @samp{2.1} or @samp{1}. @item -a range of thread numbers, again with or without an inferior +A range of thread numbers, again with or without an inferior qualifier, as in @var{inf}.@var{thr1}-@var{thr2} or @var{thr1}-@var{thr2}. E.g., @samp{1.2-4} or @samp{2-4}. @item -all threads of an inferior, specified with a star wildcard, with or +All threads of an inferior, specified with a star wildcard, with or without an inferior qualifier, as in @var{inf}.@code{*} (e.g., @samp{1.*}) or @code{*}. The former refers to all threads of the given inferior, and the latter form without an inferior qualifier -- 1.9.3