Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]

Simon Marchi
2016-02-12T18:34:21Z

On 16-02-11 04:22 PM, Jan Kratochvil wrote:
> On Mon, 08 Feb 2016 20:26:41 +0100, Simon Marchi wrote:
>> Ok, I pushed this patch. I am now waiting to know what I broke.
>
> Running /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> PASS: gdb.arch/i386-biarch-core.exp: complete set gnutarget
> PASS: gdb.arch/i386-biarch-core.exp: core-file
> PASS: gdb.arch/i386-biarch-core.exp: .text is readable
> ->
> Running /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> PASS: gdb.arch/i386-biarch-core.exp: complete set gnutarget
> UNTESTED: gdb.arch/i386-biarch-core.exp: failed bzip2
>
> Reproducible with:
> tar xJf gdb-7.10.90.20160211.tar.xz;cd gdb-7.10.90.20160211;./configure;make;make -C gdb check//unix/-m64 RUNTESTFLAGS=gdb.arch/i386-biarch-core.exp
> Running /tmp/gdb-7.10.90.20160211/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> sh: /tmp/gdb-7.10.90.20160211/gdb/testsuite.unix.-m64/gdb.arch/i386-biarch-core.core: No such file or directory
> === gdb Summary ===
> # of expected passes 1
> # of untested testcases 1
>
> I have not debugged it more yet.
>
>
> Jan

Hi Jan,

I think this patch should fix it. It simply makes the test use standard_output_file
for its output directory.

Simon

From c643fde26ecdc63c399ac4f26fd31920148fae77 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Fri, 12 Feb 2016 13:17:32 -0500
Subject: [PATCH] i386-biarch-core.exp: Use standard_output_file

Fix the core file path to use the standard output directory.

gdb/testsuite/ChangeLog:

* i386-biarch-core.exp: Define corefile using
standard_output_file.
---
gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
index 607b947..4dc5ba6 100644
--- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
+++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
@@ -40,7 +40,7 @@ gdb_test_multiple "complete set gnutarget " $test {
}

set corebz2file ${srcdir}/${subdir}/${testfile}.core.bz2
-set corefile ${objdir}/${subdir}/${testfile}.core
+set corefile [standard_output_file ${testfile}.core]
# Entry point of the original executable.
set address 0x400078

--
2.5.1