From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87050 invoked by alias); 12 Jan 2016 13:00:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87035 invoked by uid 89); 12 Jan 2016 13:00:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: Yes, score=6.1 required=5.0 tests=BAYES_00,BODY_8BITS,GARBLED_BODY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Makefiles, 201412, Hx-languages-length:1741, artifacts X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Jan 2016 13:00:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5ADEE8F289; Tue, 12 Jan 2016 13:00:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0CD02r8026158; Tue, 12 Jan 2016 08:00:02 -0500 Message-ID: <5694F8D2.5090807@redhat.com> Date: Tue, 12 Jan 2016 13:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Always organize test artifacts in a directory hierarchy References: <1452268308-23845-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1452268308-23845-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-01/txt/msg00218.txt.bz2 On 01/08/2016 03:51 PM, Simon Marchi wrote: > When running tests in parallel, each test puts its generated files in a > different directory, under "testsuite/outputs": > > outputs > ├── gdb.base > │ ├── break > │ ├── whatis > │ └── ... > ├── gdb.python > │ ├── py-type > │ ├── py-value > │ └── ... > └── ... > > I think it would be nice if it was always organized like this, even in > serial mode, as it would isolate the test cases a bit more. An artifact > created by a test wouldn't get overwritten by another test. It would be > clear which test produced which files. > Yao posted a patch that moved sequential runs to a subdir as well: https://sourceware.org/ml/gdb-patches/2014-12/msg00236.html Though I think I too prefer making sequential/parallel the same. You should cross check your patch with yours. For e.g., don't you need to mkdir -p the outputs/ dir for the first time? > It would also make it easier to clean up. Currently, make clean in the > testsuite is broken. A lot of executables are left all over the place > because their names do not appear in gdb.*/Makefile. If everything is > in "outputs", then we just have to delete that directory (which we > already do). > > At the same time it makes the gdb.foo directories and their Makefiles > useless in the build directory, since they are pretty much only used for > cleaning. Yeah, I think we all agreed to this in the past. > > Note: the performance testsuite still produces some files in gdb.perf. > If this is accepted, we can always look at that later. Agreed. > > What do you think? I like this. Thanks, Pedro Alves