From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26021 invoked by alias); 12 Jan 2016 12:46:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26007 invoked by uid 89); 12 Jan 2016 12:46:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:gdbarch, Hx-languages-length:771 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Jan 2016 12:46:55 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id B6B84C0BF2A8; Tue, 12 Jan 2016 12:46:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0CCkqLX015377; Tue, 12 Jan 2016 07:46:53 -0500 Message-ID: <5694F5BC.3050904@redhat.com> Date: Tue, 12 Jan 2016 12:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Luis Machado , "Maciej W. Rozycki" CC: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: [PATCH] Handle loading improper core files gracefully in the mips backend. References: <1452277948-25292-1-git-send-email-lgustavo@codesourcery.com> <5693CE90.1060709@codesourcery.com> In-Reply-To: <5693CE90.1060709@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00217.txt.bz2 On 01/11/2016 03:47 PM, Luis Machado wrote: > diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c > index ca17864..cdfd80e 100644 > --- a/gdb/mips-tdep.c > +++ b/gdb/mips-tdep.c > @@ -8208,6 +8208,12 @@ mips_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > int dspacc; > int dspctl; > > + /* Sanity check the e_machine field. */ > + if (info.abfd > + && bfd_get_flavour (info.abfd) == bfd_target_elf_flavour > + && elf_elfheader (info.abfd)->e_machine != EM_MIPS) > + return NULL; This callback is registered for bfd_arch_mips: gdbarch_register (bfd_arch_mips, mips_gdbarch_init, mips_dump_tdep); Does bfd think this a bfd_arch_mips binary? How so? Thanks, Pedro Alves