From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125989 invoked by alias); 8 Jan 2016 21:15:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125978 invoked by uid 89); 8 Jan 2016 21:15:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=opcodes, UD:funcargs.exp, funcargsexp, funcargs.exp X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 08 Jan 2016 21:15:20 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 05.5D.06940.CF420965; Fri, 8 Jan 2016 22:07:08 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.248.2; Fri, 8 Jan 2016 16:15:17 -0500 Subject: Re: [testsuite patch] i386 regression for funcargs.exp [Re: [PATCH 3/3] Remove HP-UX references fom testsuite] To: Jan Kratochvil , Simon Marchi References: <1450567845-27030-1-git-send-email-simon.marchi@polymtl.ca> <1450567845-27030-3-git-send-email-simon.marchi@polymtl.ca> <5677F519.2010000@redhat.com> <567831CD.2090406@redhat.com> <20160108193033.GA2812@host1.jankratochvil.net> CC: Pedro Alves , From: Simon Marchi Message-ID: <569026E5.4060502@ericsson.com> Date: Fri, 08 Jan 2016 21:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160108193033.GA2812@host1.jankratochvil.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00144.txt.bz2 On 16-01-08 02:30 PM, Jan Kratochvil wrote: > 3ca22649a6dfeb71058c33be4d0542b98f1f0ff5 is the first bad commit > commit 3ca22649a6dfeb71058c33be4d0542b98f1f0ff5 > Author: Simon Marchi > Date: Mon Dec 21 12:51:54 2015 -0500 > Remove HP-UX references fom testsuite > ### a/gdb/testsuite/gdb.base/funcargs.exp > ### b/gdb/testsuite/gdb.base/funcargs.exp > @@ -1013,13 +1013,6 @@ proc localvars_in_indirect_call { } { > # > > gdb_test_multiple "finish" "finish from indirectly called function" { > - -re "\\(\\*pointer_to_call0a\\) \\(c, s, i, l\\);.*First.*$gdb_prompt $" { > - #On hppa2.0w-hp-hpux11.00, gdb finishes at one line earlier than > - #hppa1.1-hp-hpux11.00. Therefore, an extra "step" is necessary > - #to continue the test. > - send_gdb "step\n" > - exp_continue > - } > -re ".*\\(\\*pointer_to_call0a\\) \\(c, s, i, l\\);.*Second.*$gdb_prompt $" { > pass "finish from indirectly called function" > } > > -> > > finish^M > Run till exit from #0 call0a (c=97 'a', s=1, i=2, l=3) at ./gdb.base/funcargs.c:82^M > 0x0804a189 in main () at ./gdb.base/funcargs.c:583^M > 583 (*pointer_to_call0a) (c, s, i, l); /* First step into call0a. */^M > -(gdb) step^M > -584 (*pointer_to_call0a) (c, s, i, l); /* Second step into call0a. */^M > -(gdb) PASS: gdb.base/funcargs.exp: finish from indirectly called function > +(gdb) FAIL: gdb.base/funcargs.exp: finish from indirectly called function > step^M > -call0a (c=97 'a', s=1, i=2, l=3) at ./gdb.base/funcargs.c:82^M > -82 c = 'a';^M > -(gdb) PASS: gdb.base/funcargs.exp: stepping into indirectly called function > +584 (*pointer_to_call0a) (c, s, i, l); /* Second step into call0a. */^M > +(gdb) FAIL: gdb.base/funcargs.exp: stepping into indirectly called function > > At least on x86_64 with testsuite in -m32 (expecting native i386 would be the > same). > > OK for check-in? > > > Jan I also don't see this on Ubuntu 14.04.3 LTS, gdb master, gcc 4.8.4. $ make check RUNTESTFLAGS="--target_board=unix/-m32 funcargs.exp" make[1]: Entering directory `/home/emaisin/build/binutils-gdb/gdb/testsuite' Nothing to be done for all... make check-single make[2]: Entering directory `/home/emaisin/build/binutils-gdb/gdb/testsuite' rootme=`pwd`; export rootme; srcdir=/home/emaisin/src/binutils-gdb/gdb/testsuite ; export srcdir ; EXPECT=`if [ "${READ1}" != "" ] ; then echo ${rootme}/expect-read1; elif [ -f ${rootme}/../../expect/expect ] ; then echo ${rootme}/../../expect/expect ; else echo expect ; fi` ; export EXPECT ; EXEEXT= ; export EXEEXT ; LD_LIBRARY_PATH=$rootme/../../expect:$rootme/../../libstdc++:$rootme/../../tk/unix:$rootme/../../tcl/unix:$rootme/../../bfd:$rootme/../../opcodes:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; if [ -f ${rootme}/../../expect/expect ] ; then TCL_LIBRARY=${srcdir}/../../tcl/library ; export TCL_LIBRARY ; fi ; runtest --target_board=unix/-m32 funcargs.exp WARNING: Couldn't find the global config file. Test Run By emaisin on Fri Jan 8 16:10:58 2016 Native configuration is x86_64-pc-linux-gnu === gdb tests === Schedule of variations: unix/-m32 Running target unix/-m32 Using /usr/local/share/dejagnu/baseboards/unix.exp as board description file for target. Using /usr/local/share/dejagnu/config/unix.exp as generic interface file for target. Using /home/emaisin/src/binutils-gdb/gdb/testsuite/config/unix.exp as tool-and-target-specific interface file. Running /home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.base/funcargs.exp ... === gdb Summary === # of expected passes 141 /home/emaisin/build/binutils-gdb/gdb/testsuite/../../gdb/gdb version 7.10.50.20160108-git -nw -nx -data-directory /home/emaisin/build/binutils-gdb/gdb/testsuite/../data-directory make[2]: Leaving directory `/home/emaisin/build/binutils-gdb/gdb/testsuite' make[1]: Leaving directory `/home/emaisin/build/binutils-gdb/gdb/testsuite' $ ag "finish from indirectly called function" testsuite/gdb.sum 146:PASS: gdb.base/funcargs.exp: finish from indirectly called function But if there is a configuration where this is needed, then yes, it should be re-added.