Re: [PATCH v3 4/7] Per-inferior/Inferior-qualified thread IDs

Thomas Schwinge
2016-12-07T21:10:12Z

Hi!

Better late than never... ;-)

On Thu, 07 Jan 2016 23:37:38 +0000, Pedro Alves <palves@redhat.com> wrote:
> --- a/gdb/gdbthread.h
> +++ b/gdb/gdbthread.h

> -/* Translate the integer thread id (GDB's homegrown id, not the system's)
> - into a "pid" (which may be overloaded with extra thread information). */
> -extern ptid_t thread_id_to_pid (int);
> +/* Translate the global integer thread id (GDB's homegrown id, not the
> + system's) into a "pid" (which may be overloaded with extra thread
> + information). */
> +extern ptid_t global_thread_id_to_ptid (int num);

As obvious; pushed to master:

commit 14f6890677849172a4b13779acd9089c9baa3a81
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Tue May 24 19:36:57 2016 +0200

Hurd: Adjust to "Per-inferior/Inferior-qualified thread IDs" changes

[...]/gdb/gnu-nat.c: In function 'set_sig_thread_cmd':
[...]/gdb/gnu-nat.c:2973:7: warning: implicit declaration of function 'thread_id_to_pid' [-Wimplicit-function-declaration]
ptid_t ptid = thread_id_to_pid (atoi (args));
^
[...]/gdb/gnu-nat.c:2973:7: error: invalid initializer

That's commit 5d5658a1d3c3eb2a09c03f2f0662a1c01963c869, which renamed
`thread_id_to_pid` to `global_thread_id_to_ptid`.

gdb/
* gnu-nat.c (set_sig_thread_cmd): Call global_thread_id_to_ptid
instead of thread_id_to_pid.
---
gdb/ChangeLog | 5 +++++
gdb/gnu-nat.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)

diff --git gdb/ChangeLog gdb/ChangeLog
index c251150..61d1205 100644
--- gdb/ChangeLog
+++ gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-12-07 Thomas Schwinge <thomas@codesourcery.com>
+
+ * gnu-nat.c (set_sig_thread_cmd): Call global_thread_id_to_ptid
+ instead of thread_id_to_pid.
+
2016-12-06 Simon Marchi <simon.marchi@ericsson.com>

* inferior.c (inferior_command): Remove duplicate
diff --git gdb/gnu-nat.c gdb/gnu-nat.c
index 927ee5c..92b9292 100644
--- gdb/gnu-nat.c
+++ gdb/gnu-nat.c
@@ -2964,7 +2964,7 @@ set_sig_thread_cmd (char *args, int from_tty)
inf->signal_thread = 0;
else
{
- ptid_t ptid = thread_id_to_pid (atoi (args));
+ ptid_t ptid = global_thread_id_to_ptid (atoi (args));

if (ptid_equal (ptid, minus_one_ptid))
error (_("Thread ID %s not known. "

Grüße
Thomas