From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77790 invoked by alias); 6 Jan 2016 14:50:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77774 invoked by uid 89); 6 Jan 2016 14:50:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*r:Symantec X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 06 Jan 2016 14:50:08 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id FE.E8.32102.1992D865; Wed, 6 Jan 2016 15:49:54 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Wed, 6 Jan 2016 09:50:05 -0500 Subject: Re: [PATCH v8 5/7] Support software single step on ARM in GDBServer To: Yao Qi References: <1450361684-29536-1-git-send-email-antoine.tremblay@ericsson.com> <1450361684-29536-6-git-send-email-antoine.tremblay@ericsson.com> <8660z6ydkq.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <568D299D.5040202@ericsson.com> Date: Wed, 06 Jan 2016 14:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <8660z6ydkq.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00092.txt.bz2 On 01/06/2016 09:42 AM, Yao Qi wrote: > Antoine Tremblay writes: > > Hi Antoine, > >> +/* Find the next possible PCs for thumb mode. */ >> +VEC (CORE_ADDR) *thumb_get_next_pcs_raw (struct arm_get_next_pcs *self, >> + CORE_ADDR pc); >> + >> +/* Find the next possible PCs for arm mode. */ >> +VEC (CORE_ADDR) *arm_get_next_pcs_raw (struct arm_get_next_pcs *self, >> + CORE_ADDR pc); >> + >> +#endif /* ARM_GET_NEXT_PCS_H */ > > Is there any reason to make them extern? I have a patch below to make > them static. What do you think? > No indeed they should be static. Sounds like a relic of a past implementation. Thanks, Antoine