From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104464 invoked by alias); 6 Jan 2016 14:36:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104452 invoked by uid 89); 6 Jan 2016 14:36:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:1639, H*r:Symantec X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 06 Jan 2016 14:36:12 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 3D.6E.06940.C842D865; Wed, 6 Jan 2016 15:28:29 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.248.2; Wed, 6 Jan 2016 09:36:09 -0500 Subject: Re: [PATCH v8 5/7] Support software single step on ARM in GDBServer To: Yao Qi References: <1450361684-29536-1-git-send-email-antoine.tremblay@ericsson.com> <1450361684-29536-6-git-send-email-antoine.tremblay@ericsson.com> <86a8oiyegx.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <568D2659.20603@ericsson.com> Date: Wed, 06 Jan 2016 14:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <86a8oiyegx.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00090.txt.bz2 On 01/06/2016 09:22 AM, Yao Qi wrote: > Antoine Tremblay writes: > > Hi Antoine, > >> --- a/gdb/gdbserver/linux-aarch32-low.h >> +++ b/gdb/gdbserver/linux-aarch32-low.h >> @@ -15,6 +15,27 @@ >> You should have received a copy of the GNU General Public License >> along with this program. If not, see . */ >> >> +/* Correct in either endianness. */ >> +#define arm_abi_breakpoint 0xef9f0001UL >> + >> +/* For new EABI binaries. We recognize it regardless of which ABI >> + is used for gdbserver, so single threaded debugging should work >> + OK, but for multi-threaded debugging we only insert the current >> + ABI's breakpoint instruction. For now at least. */ >> +#define arm_eabi_breakpoint 0xe7f001f0UL >> + >> +#ifndef __ARM_EABI__ >> +static const unsigned long arm_breakpoint = arm_abi_breakpoint; >> +#else >> +static const unsigned long arm_breakpoint = arm_eabi_breakpoint; >> +#endif >> + >> +#define arm_breakpoint_len 4 >> +static const unsigned short thumb_breakpoint = 0xde01; >> +#define thumb_breakpoint_len 2 >> +static const unsigned short thumb2_breakpoint[] = { 0xf7f0, 0xa000 }; >> +#define thumb2_breakpoint_len 4 >> + > > This change causes GDBserver build errors on both ARM and AArch64, which > are shown in the commit log of the patch below. > Strange I did not see those at all with arm-linux-gnueabihf-gcc (Ubuntu/Linaro 4.8.2-16ubuntu4) 4.8.2 Ideas on why you see those and I would not ? Looking forward to your follow up patches about the issues revealed... Thanks, Antoine