From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39166 invoked by alias); 4 Jan 2016 13:57:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39151 invoked by uid 89); 4 Jan 2016 13:57:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*atmel.com, choices, 2117, unwind X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 04 Jan 2016 13:57:39 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C5C9EF5DC3; Mon, 4 Jan 2016 13:57:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u04DvZqO016819; Mon, 4 Jan 2016 08:57:36 -0500 Message-ID: <568A7A4F.2060504@redhat.com> Date: Mon, 04 Jan 2016 13:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Sivanupandi, Pitchumani" , "troth@openavr.org" , "brobecker@adacore.com" , "gdb-patches@sourceware.org" Subject: Re: [patch] Enable dwarf unwind for AVR target References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00036.txt.bz2 On 01/04/2016 08:01 AM, Sivanupandi, Pitchumani wrote: > - AVR_NUM_PSEUDO_REGS = 1, > + AVR_DWARF2_PC_REGNUM = 36 /*LR*/, It's hard to comment without some explanation for the design choices in the patch, and/or some understanding of what this register is. Seems odd that you create the register and then avr_pseudo_register_read already returns ? Why did you need to add it? Is this a real machine register? What's LR? > + AVR_NUM_PSEUDO_REGS = 2, > > AVR_PC_REG_INDEX = 35, /* index into array of registers */ > > @@ -211,7 +213,7 @@ avr_register_name (struct gdbarch *gdbarch, int regnum) > "r16", "r17", "r18", "r19", "r20", "r21", "r22", "r23", > "r24", "r25", "r26", "r27", "r28", "r29", "r30", "r31", > "SREG", "SP", "PC2", > - "pc" > + "pc", "LR" > }; Thanks, Pedro Alves