From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96494 invoked by alias); 18 Dec 2015 23:49:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96474 invoked by uid 89); 18 Dec 2015 23:49:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=withdraw, UD:gdb.log, gdblog, gdb.log X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Dec 2015 23:49:33 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1aA4mA-0005ew-C4 from Sandra_Loosemore@mentor.com ; Fri, 18 Dec 2015 15:49:30 -0800 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Fri, 18 Dec 2015 15:49:29 -0800 Subject: Re: [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp To: Pedro Alves , gdb-patches References: <56745D29.504@codesourcery.com> <5674636B.6090507@codesourcery.com> <56746F26.1040903@redhat.com> From: Sandra Loosemore Message-ID: <56749B6C.7000804@codesourcery.com> Date: Fri, 18 Dec 2015 23:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56746F26.1040903@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00392.txt.bz2 On 12/18/2015 01:40 PM, Pedro Alves wrote: > On 12/18/2015 07:50 PM, Sandra Loosemore wrote: >> This patch fixes a think-o in gdb.base/paginate-bg-execution.exp -- >> there are two calls to gdb_test with only a single argument. Looking at >> the definition of this proc in lib/gdb.exp, the second argument (the >> output pattern) is not supposed to be optional. For whatever reason, I >> was only seeing failures on remote Windows host testing, but it must >> have been an accident that it appeared to be working elsewhere. >> >> I copied the breakpoint output pattern used elsewhere in the testsuite, >> and confirmed this passes now. OK to commit? > > Can you show the gdb.log of the failed run? Hmmmm. I lost the original log, and now I cannot reproduce the failure. I must be losing my marbles. :-( Is it supposed to be correct to call gdb_test with only one argument? If yes, I'll withdraw this patch and submit another one to tweak the comments in lib/gdb.exp to explicitly say the pattern arg is optional. -Sandra