From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105214 invoked by alias); 18 Dec 2015 19:34:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105205 invoked by uid 89); 18 Dec 2015 19:34:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=HTo:U*sandra X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Dec 2015 19:34:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id D042531D8A2; Fri, 18 Dec 2015 19:34:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBIJY7pK006358; Fri, 18 Dec 2015 14:34:07 -0500 Message-ID: <56745FAF.4040501@redhat.com> Date: Fri, 18 Dec 2015 19:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sandra Loosemore , gdb-patches Subject: Re: [patch 1/3] make prompt_for_continue call throw_quit directly References: <56745D29.504@codesourcery.com> <56745ED5.9020309@codesourcery.com> In-Reply-To: <56745ED5.9020309@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00385.txt.bz2 On 12/18/2015 07:30 PM, Sandra Loosemore wrote: > This is the patch previously suggested by Pedro here: > > https://sourceware.org/ml/gdb-patches/2015-09/msg00637.html > > to fix a problem I ran into when testing on a remote Windows host via > SSH without a terminal or job control. As Pedro said, when typing 'q' > in response to a pagination prompt, there's no possibility of a SIGINT > so we can bypass the parts of quit() handling that are intended to > intercept ^C instead. > > I confirmed that this fixes the bogus quit message I observed previously > on Windows host, and did full regression testing on Linux host for > nios2-linux-gnu target. > > OK to commit? OK. Could you add a little comment to prevent someone from deciding later that we should using quit() instead? Thanks, Pedro Alves