From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18464 invoked by alias); 18 Dec 2015 18:48:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18452 invoked by uid 89); 18 Dec 2015 18:48:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*f:sk:001a114, sk:python, sk:python- X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Dec 2015 18:48:15 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 831BAC0AF3DE; Fri, 18 Dec 2015 18:48:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBIImDPI026879; Fri, 18 Dec 2015 13:48:13 -0500 Message-ID: <567454ED.10204@redhat.com> Date: Fri, 18 Dec 2015 18:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joel Brobecker , Doug Evans CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Add function host_string_to_python_string. References: <001a11438f7c8987ea05272ff754@google.com> <20151218182436.GG29928@adacore.com> In-Reply-To: <20151218182436.GG29928@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00380.txt.bz2 On 12/18/2015 06:24 PM, Joel Brobecker wrote: >> There's a python_string_to_host_string function, but not its counterpart. >> I couldn't find anything in the record arguing against its existence, >> and there's enough of a use for it so I added it. >> >> Regression tested on amd64-linux. >> >> 2015-12-18 Doug Evans >> >> * python/py-utils.c (host_string_to_python_string): New function. >> * python/python-internal.h (host_string_to_python_string): Declare it. >> * python/py-*.c (*): Update all calls to >> PyString_Decode (str, strlen (str), host_charset (), NULL) >> to use host_string_to_python_string (str) instead. > > FWIW, looking at the alternative, I find the new one much better, > so that's a nice addition, IMO. Agreed. Thanks, Pedro Alves