From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45520 invoked by alias); 18 Dec 2015 12:55:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45510 invoked by uid 89); 18 Dec 2015 12:55:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=imperative, 724, regset, 2467 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Dec 2015 12:55:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 52212425AF; Fri, 18 Dec 2015 12:55:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBICtbuo002320; Fri, 18 Dec 2015 07:55:38 -0500 Message-ID: <56740249.4020105@redhat.com> Date: Fri, 18 Dec 2015 12:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Walfred Tedeschi , brobecker@adacore.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH V2 3/5] Use linux_get_siginfo_type_with_fields for x86. References: <1450371416-24270-1-git-send-email-walfred.tedeschi@intel.com> <1450371416-24270-3-git-send-email-walfred.tedeschi@intel.com> In-Reply-To: <1450371416-24270-3-git-send-email-walfred.tedeschi@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00360.txt.bz2 On 12/17/2015 04:56 PM, Walfred Tedeschi wrote: > Using new functions introduced for siginfo for i386/amd64. > > > 2015-12-15 Walfred Tedeschi > > * linux-tdep.h (linux_get_siginfo_type_with_fields): Making > function linux_get_siginfo_type_with_fields public. > * linux-tdep.c (linux_get_siginfo_type_with_fields): Making > function linux_get_siginfo_type_with_fields public. Use imperative: "Use", "Make" (here and elsewhere, including subject line of patch #1. Drop periods in subject lines while at it). s/public/extern/. > * i386-linux-tdep.h (x86_get_siginfo_type_with_fields): New > function. > * amd64-linux-tdep.c (amd64_linux_init_abi_common): Add > x86_get_siginfo_type_with_fields for the amd64 abi. (amd64_linux_init_abi_common): Register as gdbarch_get_siginfo_type method. > * i386-linux-tdep.c (x86_get_siginfo_type_with_fields): New > Function. lowercase "function". > (i386_linux_init_abi): Add new function at the i386 ABI > initialization. (i386_linux_init_abi): Register as gdbarch_get_siginfo_type method. > > --- > gdb/amd64-linux-tdep.c | 2 ++ > gdb/i386-linux-tdep.c | 8 ++++++++ > gdb/i386-linux-tdep.h | 3 +++ > gdb/linux-tdep.c | 2 +- > gdb/linux-tdep.h | 5 +++++ > 5 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c > index ee21635..bde751f 100644 > --- a/gdb/amd64-linux-tdep.c > +++ b/gdb/amd64-linux-tdep.c > @@ -1838,6 +1838,8 @@ amd64_linux_init_abi_common(struct gdbarch_info info, struct gdbarch *gdbarch) > > set_gdbarch_process_record (gdbarch, i386_process_record); > set_gdbarch_process_record_signal (gdbarch, amd64_linux_record_signal); > + > + set_gdbarch_get_siginfo_type (gdbarch, x86_get_siginfo_type_with_fields); > } > > static void > diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c > index 86fe09e..766f193 100644 > --- a/gdb/i386-linux-tdep.c > +++ b/gdb/i386-linux-tdep.c > @@ -656,6 +656,12 @@ i386_linux_supply_xstateregset (const struct regset *regset, > i387_supply_xsave (regcache, regnum, xstateregs); > } > > +struct type * > +x86_get_siginfo_type_with_fields (struct gdbarch *gdbarch) "with_fields" is implementation detail. I'd rather just: struct type * x86_get_siginfo_type (struct gdbarch *gdbarch) > +{ > + return linux_get_siginfo_type_with_fields (gdbarch, LINUX_SIGINFO_FIELD_ADDR_BND); > +} > + > /* Similar to i386_collect_fpregset, but use XSAVE extended state. */ > > static void > @@ -994,6 +1000,8 @@ i386_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > set_xml_syscall_file_name (gdbarch, XML_SYSCALL_FILENAME_I386); > set_gdbarch_get_syscall_number (gdbarch, > i386_linux_get_syscall_number); > + > + set_gdbarch_get_siginfo_type (gdbarch, x86_get_siginfo_type_with_fields); > } > > /* Provide a prototype to silence -Wmissing-prototypes. */ > diff --git a/gdb/i386-linux-tdep.h b/gdb/i386-linux-tdep.h > index 5ac08d3..f42bf7a 100644 > --- a/gdb/i386-linux-tdep.h > +++ b/gdb/i386-linux-tdep.h > @@ -72,4 +72,7 @@ extern struct target_desc *tdesc_i386_avx512_linux; > > extern int i386_linux_gregset_reg_offset[]; > > +/* Returns x86 siginfo type with extra fields. */ /* Return the x86 siginfo type. */ > +extern struct type *x86_get_siginfo_type_with_fields (struct gdbarch *gdbarch); > + > #endif /* i386-linux-tdep.h */ > diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c > index a7e85c5..e41b6f4 100644 > --- a/gdb/linux-tdep.c > +++ b/gdb/linux-tdep.c > @@ -246,7 +246,7 @@ get_linux_inferior_data (void) > /* This function is suitable for architectures that > extend/override the standard siginfo in an specific way. */ > Update comment: /* See linux-tdep.h. */ > -static struct type * > +struct type * > linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch, > linux_siginfo_extra_fields extra_fields) > { > diff --git a/gdb/linux-tdep.h b/gdb/linux-tdep.h > index c0c9d91..7592259 100644 > --- a/gdb/linux-tdep.h > +++ b/gdb/linux-tdep.h > @@ -33,6 +33,11 @@ enum linux_siginfo_extra_field_values > /* Defines a type for the values defined in linux_siginfo_extra_field_values. */ > DEF_ENUM_FLAGS_TYPE (enum linux_siginfo_extra_field_values, linux_siginfo_extra_fields); > > +/* Return the siginfo type with additional fields. */ > +struct type * > +linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch, > + linux_siginfo_extra_fields fields); > + /* Return a new siginfo type with additional fields specified by FIELDS. */ struct type *linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch, linux_siginfo_extra_fields fields); > typedef char *(*linux_collect_thread_registers_ftype) (const struct regcache *, > ptid_t, > bfd *, char *, int *, > Thanks, Pedro Alves