From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15690 invoked by alias); 16 Dec 2015 15:59:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15668 invoked by uid 89); 16 Dec 2015 15:59:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Dec 2015 15:59:54 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 0AEA3693C6; Wed, 16 Dec 2015 15:59:53 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBGFxpS2003303; Wed, 16 Dec 2015 10:59:52 -0500 Message-ID: <56718A77.5050305@redhat.com> Date: Wed, 16 Dec 2015 15:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH v7 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr. References: <1449583641-18156-1-git-send-email-antoine.tremblay@ericsson.com> <1449583641-18156-4-git-send-email-antoine.tremblay@ericsson.com> <86io45ql3x.fsf@gmail.com> <566ABA91.5000508@redhat.com> <566ABB44.3080004@gmail.com> <566ABC0C.10101@redhat.com> <566AC23B.6060800@ericsson.com> <56700B8D.2090302@ericsson.com> In-Reply-To: <56700B8D.2090302@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00301.txt.bz2 On 12/15/2015 12:46 PM, Antoine Tremblay wrote: > > > On 12/11/2015 07:31 AM, Antoine Tremblay wrote: >> >> >> On 12/11/2015 07:05 AM, Pedro Alves wrote: >>> On 12/11/2015 12:02 PM, Yao Qi wrote: >>>> On 11/12/15 11:59, Pedro Alves wrote: >>>>> but then you might as well just do: >>>>> >>>>> #define ARM_SIGRETURN 119 >>>> >>>> How about using __NR_sigreturn and __NR_rt_sigreturn directly? like >>>> what patch #6 does. >>> >>> Those are host/native macros. Only make sense for the running host. >>> Can't use that in a tdep file, like arm-linux-tdep.c. Otherwise, e.g., >>> a x86-hosted cross debugger would be using the x86 __NR_sigreturn, etc. >>> >> >> Exactly that's why I use those only in GDBServer. >> >> Personally while I like the #define ARM_SIGRETURN 119 better, I think >> the xml function is fine. > > Any news about this one ? > > Given that I use xml in GDB and __NR_sigreturn macros in GDBServer... > > Is the patch OK ? I'd rather leave the final call to Yao. Thanks, Pedro Alves