From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17553 invoked by alias); 11 Dec 2015 13:41:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17529 invoked by uid 89); 11 Dec 2015 13:41:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 11 Dec 2015 13:41:05 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 84.1E.32102.A62DA665; Fri, 11 Dec 2015 14:40:58 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Fri, 11 Dec 2015 08:41:02 -0500 Subject: Re: [PATCH v7.1] Support software single step on ARM in GDBServer. To: Yao Qi References: <1449583641-18156-7-git-send-email-antoine.tremblay@ericsson.com> <1449691701-11845-1-git-send-email-antoine.tremblay@ericsson.com> <867fklqflh.fsf@gmail.com> <566AD173.2060509@ericsson.com> CC: From: Antoine Tremblay Message-ID: <566AD26E.5060902@ericsson.com> Date: Fri, 11 Dec 2015 13:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <566AD173.2060509@ericsson.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00232.txt.bz2 On 12/11/2015 08:36 AM, Antoine Tremblay wrote: > > > On 12/11/2015 08:28 AM, Yao Qi wrote: >> Antoine Tremblay writes: >> >>> * linux-aarch32-low.c (arm_abi_breakpoint): Remove macro. Moved >>> to linux-aarch32-low.c. >>> (arm_eabi_breakpoint, arm_breakpoint): Likewise. >>> (arm_breakpoint_len, thumb_breakpoint): Likewise. >>> (thumb_breakpoint_len, thumb2_breakpoint): Likewise. >>> (thumb2_breakpoint_len): Likewise. >> >> I don't see how are they used outside of linux-aarch32-low.c, so why do >> you move them out to linux-aarch32-low.h? >> > > That's true, I guess I was used to breakpoint functions in linux-arm-low.c. > > Fixing this now. > Ooops no this is correct after all arm_gdbserver_get_next_pcs (CORE_ADDR pc, struct regcache *regcache) in linux-arm-low is using &thumb2_breakpoint. I think it's better to have them all the the same area also, so it's ok to have them there. Thanks, Antoine.