From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105397 invoked by alias); 11 Dec 2015 12:47:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105342 invoked by uid 89); 11 Dec 2015 12:47:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Dec 2015 12:47:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 2B71F68E18; Fri, 11 Dec 2015 12:47:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBBClcb7022214; Fri, 11 Dec 2015 07:47:39 -0500 Message-ID: <566AC5EA.4090204@redhat.com> Date: Fri, 11 Dec 2015 12:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH v7 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr. References: <1449583641-18156-1-git-send-email-antoine.tremblay@ericsson.com> <1449583641-18156-4-git-send-email-antoine.tremblay@ericsson.com> <86io45ql3x.fsf@gmail.com> <566ABA91.5000508@redhat.com> <566ABB44.3080004@gmail.com> <566ABC0C.10101@redhat.com> <566AC23B.6060800@ericsson.com> In-Reply-To: <566AC23B.6060800@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00226.txt.bz2 On 12/11/2015 12:31 PM, Antoine Tremblay wrote: > > > On 12/11/2015 07:05 AM, Pedro Alves wrote: >> On 12/11/2015 12:02 PM, Yao Qi wrote: >>> On 11/12/15 11:59, Pedro Alves wrote: >>>> but then you might as well just do: >>>> >>>> #define ARM_SIGRETURN 119 >>> >>> How about using __NR_sigreturn and __NR_rt_sigreturn directly? like >>> what patch #6 does. >> >> Those are host/native macros. Only make sense for the running host. >> Can't use that in a tdep file, like arm-linux-tdep.c. Otherwise, e.g., >> a x86-hosted cross debugger would be using the x86 __NR_sigreturn, etc. >> > > Exactly that's why I use those only in GDBServer. Hmm, actually, that sounds wrong. What about Aarch64 gdbserver debugging Aarch32? I see that the new code in question in patch #6 is in gdbserver/linux-arm-low.c, which is not built on Aarch64, but, shouldn't that new arm_sigreturn_next_pc code be used in the biarch scenario as well? If you just made that 32-bit-specific code compile on Aarch64 it would be compiling against Aarch64's __NR_sigreturn, which I'd assume is wrong for Aarch32. > > Personally while I like the #define ARM_SIGRETURN 119 better, I think > the xml function is fine. > If you added #define ARM_LINUX_SIGRETURN 119 to arch/arm-linux.h you could use it in both places. Thanks, Pedro Alves