From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128133 invoked by alias); 11 Dec 2015 12:29:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128123 invoked by uid 89); 11 Dec 2015 12:29:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 11 Dec 2015 12:29:33 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id AD.4B.32102.6A1CA665; Fri, 11 Dec 2015 13:29:26 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Fri, 11 Dec 2015 07:29:31 -0500 Subject: Re: [PATCH v7 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr. To: Yao Qi References: <1449583641-18156-1-git-send-email-antoine.tremblay@ericsson.com> <1449583641-18156-4-git-send-email-antoine.tremblay@ericsson.com> <86io45ql3x.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <566AC1AA.3030007@ericsson.com> Date: Fri, 11 Dec 2015 12:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <86io45ql3x.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00223.txt.bz2 On 12/11/2015 06:29 AM, Yao Qi wrote: > Antoine Tremblay writes: > >> It also adds a new function to xml-syscall.h/c to compare syscalls numbers >> called is_syscall. > > Why don't we use existing get_syscall_by_name in > arm_linux_sigreturn_return_addr rather than adding a new function is_syscall? > This is because it complicated the code a lot just to compare a syscall I have to do what is in the is_syscall function. And I have to do that over and over... so might as well be in a function ?