Re: [PATCH v7.1 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr

Antoine Tremblay
2015-12-17T12:51:31Z

On 12/17/2015 05:17 AM, Pedro Alves wrote:
>
> You also need a dummy version of the function under
>
> #ifndef HAVE_LIBEXPAT
>
> in order to avoid breaking the build when expat is not available.
>

Right indeed thx.

> BTW, I think this patch now makes libexpat a hard requirement
> for basic ARM Linux debugging.
>

OK I had not considered that at first, that sounds wrong to me compared
to the option of having a #define and no hard requirement on expat.

On the other hand expat is needed for debugging with GDBServer...

Yao, had you considered this ?

Is it not better to have a #define considering this ?

Thanks,
Antoine