Re: [PATCH v7.1] Support software single step on ARM in GDBServer.

Antoine Tremblay
2015-12-11T13:41:06Z

On 12/11/2015 08:36 AM, Antoine Tremblay wrote:
>
>
> On 12/11/2015 08:28 AM, Yao Qi wrote:
>> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>>
>>> * linux-aarch32-low.c (arm_abi_breakpoint): Remove macro. Moved
>>> to linux-aarch32-low.c.
>>> (arm_eabi_breakpoint, arm_breakpoint): Likewise.
>>> (arm_breakpoint_len, thumb_breakpoint): Likewise.
>>> (thumb_breakpoint_len, thumb2_breakpoint): Likewise.
>>> (thumb2_breakpoint_len): Likewise.
>>
>> I don't see how are they used outside of linux-aarch32-low.c, so why do
>> you move them out to linux-aarch32-low.h?
>>
>
> That's true, I guess I was used to breakpoint functions in linux-arm-low.c.
>
> Fixing this now.
>
Ooops no this is correct after all

arm_gdbserver_get_next_pcs (CORE_ADDR pc, struct regcache *regcache)

in linux-arm-low is using &thumb2_breakpoint.

I think it's better to have them all the the same area also, so it's ok
to have them there.

Thanks,
Antoine.