From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115421 invoked by alias); 10 Dec 2015 19:34:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115398 invoked by uid 89); 10 Dec 2015 19:34:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Dec 2015 19:34:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 771C88E3E7; Thu, 10 Dec 2015 19:34:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBAJYNTQ030038; Thu, 10 Dec 2015 14:34:23 -0500 Message-ID: <5669D3BE.9050205@redhat.com> Date: Thu, 10 Dec 2015 19:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix regression revealed by corethreads.exp References: <1449774866-18369-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1449774866-18369-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00212.txt.bz2 On 12/10/2015 07:14 PM, Antoine Tremblay wrote: > This patch fixes a regression introduced by: > https://sourceware.org/ml/gdb-patches/2015-12/msg00192.html > > We can't use thread_from_lwp with core files. As mentioned in a comment, > td_ta_map_lwp2thr uses ps_get_thread_area, but we can't use that > currently on core targets, as it uses ptrace directly. > > Use directly record_thread instead. > > This fixes : > PASS -> FAIL: gdb.threads/corethreads.exp: thread0 found > PASS -> FAIL: gdb.threads/corethreads.exp: thread1 found > > gdb/ChangeLog: > > * linux-thread-db.c (find_new_threads_callback): Use record_thread. OK. Thanks, Pedro Alves