From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107987 invoked by alias); 10 Dec 2015 14:48:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107912 invoked by uid 89); 10 Dec 2015 14:47:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Dec 2015 14:47:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9FC6142E5A6; Thu, 10 Dec 2015 14:47:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBAElrqR001857; Thu, 10 Dec 2015 09:47:54 -0500 Message-ID: <56699099.2080908@redhat.com> Date: Thu, 10 Dec 2015 14:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH] Remove support for thread events without PTRACE_EVENT_CLONE in GDB. References: <1449682744-11243-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1449682744-11243-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00190.txt.bz2 On 12/09/2015 05:39 PM, Antoine Tremblay wrote: > Before, on systems that did not support PTRACE_EVENT_CLONE, both GDB and > GDBServer coordinated with libthread_db.so to insert breakpoints at magic > locations in libpthread.so, in order to break at thread creation and > thread death. > > Support for thread events was removed from GDBServer as patch: > https://sourceware.org/ml/gdb-patches/2015-11/msg00466.html > > This patch removes support for thread events in GDB. > > No regressions found on Ubuntu 14.04 x86_64. > > gdb/ChangeLog: > * breakpoint.c (create_thread_event_breakpoint): Remove. > (remove_thread_event_breakpoints): Remove. That's still used: $ grep create_thread_event_breakpoint gdb/* gdb/aix-thread.c: if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr)) > - /* Under GNU/Linux, we have to attach to each and every thread. */ > - if (target_has_execution > - && tp == NULL) > - { > - int res; > - > - res = lin_lwp_attach_lwp (ptid_build (ptid_get_pid (ptid), > - ti_p->ti_lid, 0)); > - if (res < 0) > - { > - /* Error, stop iterating. */ Is lin_lwp_attach_lwp used anywhere after this? > @@ -1592,24 +1200,10 @@ find_new_threads_callback (const td_thrhandle_t *th_p, void *data) > > if (ti.ti_tid == 0) > { > - /* A thread ID of zero means that this is the main thread, but > - glibc has not yet initialized thread-local storage and the > - pthread library. We do not know what the thread's TID will > - be yet. Just enable event reporting and otherwise ignore > - it. */ You shouldn't remove the whole comment -- it's still all correct except the last sentence. Thanks, Pedro Alves