From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120116 invoked by alias); 9 Dec 2015 11:23:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120090 invoked by uid 89); 9 Dec 2015 11:23:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Dec 2015 11:23:30 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E59AF42E5D6; Wed, 9 Dec 2015 11:23:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB9BNRew002132; Wed, 9 Dec 2015 06:23:27 -0500 Message-ID: <56680F2F.7050408@redhat.com> Date: Wed, 09 Dec 2015 11:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Tristan Gingold , GDB Patches Subject: Re: [PATCH/aarch64] Fix handling of hfa/hva arrays References: <9807AC8E-AB8B-42D5-BEF8-1CF4D5731E28@adacore.com> In-Reply-To: <9807AC8E-AB8B-42D5-BEF8-1CF4D5731E28@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-12/txt/msg00176.txt.bz2 On 12/09/2015 11:04 AM, Tristan Gingold wrote: > Hello, > > the current handling of hfa arrays is not correct: first the length comparison > is using the size instead of the length so only array of a single float could > be considered as an hfa. > > Second, where used HFA were only considered as struct/union. Incorrect > accessor (like TYPE_NFIELDS) were used on arrays. > > Unfortunately, we don’t have the setup to run the gdb testsuite on that > processor. So this patch was only manually tested (using our own > internal testsuite) on a slightly older version of gdb. Note there are now 4 Aarch64 Ubuntu machines available on the gcc compile farm: gcc113-gcc116. Thanks, Pedro Alves