From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60557 invoked by alias); 8 Dec 2015 09:22:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60539 invoked by uid 89); 8 Dec 2015 09:22:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Dec 2015 09:22:30 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id C49DA3000A8F; Tue, 8 Dec 2015 10:22:27 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cx46mR39zsbN; Tue, 8 Dec 2015 10:22:27 +0100 (CET) Received: from [10.10.1.112] (cacatoes.act-europe.fr [10.10.1.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id A9CAC3000A83; Tue, 8 Dec 2015 10:22:27 +0100 (CET) Subject: Re: [PATCH] DOCO: Enhance the menu to select function overloads with signatures To: Eli Zaretskii References: <1449491748-2677-1-git-send-email-derodat@adacore.com> <83egeydzat.fsf@gnu.org> Cc: gdb-patches@sourceware.org, brobecker@adacore.com From: Pierre-Marie de Rodat Message-ID: <5666A153.8040209@adacore.com> Date: Tue, 08 Dec 2015 09:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <83egeydzat.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00151.txt.bz2 On 12/07/2015 05:00 PM, Eli Zaretskii wrote: >> +* In Ada, the overloads selection menu has been enhance to display the > ^^^^^^^ > "enhanced" Fixed. >> +show ada print-signatures" >> + Control whether parameter types and return types are displayed in overloads >> + selection menus. It is activaled (@code{on}) by default. > ^^ > Two spaces between sentences, please. Fixed here and in the other occurence. > This index entry is backwards: it should be "overloading, Ada". > That's because the reader is much more likely to think of > "overloading" than of "Ada" when she wants to look up this entry. Fixed, thank you for the rationale. >> +If, after narrowing, the set of matching definitions still contains more than >> +one definition, GDB will display a menu to query which one it should use, for > ^^^ > "@value{GDBN}" Fixed. > @kbd{0} and @key{RET}, respectively. These are GNU conventions for > markup of user input and key names. Done, thanks. >> +specific overloaded entity (type the corresponding number and press > > Won't "specific instance" be more accurate? Those entries are no > longer overloaded, are they? I’m not sure what you mean here: the reason we have this menu is because the name “f” is overloaded (i.e. multiple entities have the same name). They still have the same name when the user is about to select one of them, so they are still overloaded. … Anyway I switched to “specific instance” as it’s correct. ;-) >> +@code{ENTER}). > > @key{RET}. Fixed. >> +@kindex set ada print-signatures >> +@item set ada print-signatures >> +Control whether parameter types and return types are displayed in overloads >> +selection menus. It is activaled (@code{on}) by default. > ^^ > Two spaces where indicated. Also, I thing you can safely delete > "activated" and leave just @code{on} without parentheses. Done. >> +@pxref{Overloading support for Ada} > > @xref, not @pxref, and place a period after the closing brace. Fixed the two occurences. > OK with these fixed. > > Thanks. Pushed now. Many thanks for reviewing! -- Pierre-Marie de Rodat