From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38715 invoked by alias); 7 Dec 2015 14:51:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37955 invoked by uid 89); 7 Dec 2015 14:51:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 07 Dec 2015 14:51:47 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 79.95.32102.DFC95665; Mon, 7 Dec 2015 15:51:41 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.92) with Microsoft SMTP Server id 14.3.248.2; Mon, 7 Dec 2015 09:51:44 -0500 Subject: Re: [PATCH v6 3/7] Refactor arm_software_single_step to use regcache. To: Yao Qi References: <1449254773-19019-1-git-send-email-antoine.tremblay@ericsson.com> <1449254773-19019-4-git-send-email-antoine.tremblay@ericsson.com> <867fkqs46g.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <56659D00.3090101@ericsson.com> Date: Mon, 07 Dec 2015 14:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <867fkqs46g.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00135.txt.bz2 On 12/07/2015 09:51 AM, Yao Qi wrote: > Antoine Tremblay writes: > >> + pc_offset = r0_offset + 4 * 15; > > Replace magic numbers with INT_REGISTER_SIZE * ARM_PC_REGNUM? > OK.