From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33188 invoked by alias); 5 Dec 2015 02:14:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33169 invoked by uid 89); 5 Dec 2015 02:14:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 05 Dec 2015 02:14:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9E88E5BA03; Sat, 5 Dec 2015 02:14:52 +0000 (UTC) Received: from [10.3.113.46] (ovpn-113-46.phx2.redhat.com [10.3.113.46]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB52Epvh000447; Fri, 4 Dec 2015 21:14:51 -0500 Subject: Re: [PATCH v3 2/2] Implement 'catch syscall' for gdbserver To: Eli Zaretskii References: <1448506425-24691-1-git-send-email-jistone@redhat.com> <1449196006-13759-1-git-send-email-jistone@redhat.com> <1449196006-13759-2-git-send-email-jistone@redhat.com> <837fkuiovv.fsf@gnu.org> Cc: gdb-patches@sourceware.org, philippe.waroquiers@skynet.be, sergiodj@redhat.com, palves@redhat.com, xdje42@gmail.com From: Josh Stone Message-ID: <5662489B.20708@redhat.com> Date: Sat, 05 Dec 2015 02:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <837fkuiovv.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00097.txt.bz2 On 12/04/2015 12:44 AM, Eli Zaretskii wrote: >> From: Josh Stone >> Cc: philippe.waroquiers@skynet.be, sergiodj@redhat.com, palves@redhat.com, eliz@gnu.org, xdje42@gmail.com, Josh Stone >> Date: Thu, 3 Dec 2015 18:26:46 -0800 >> >> This adds a new QCatchSyscalls packet to enable 'catch syscall', and new >> stop reasons "syscall_entry" and "syscall_return" for those events. It >> is currently only supported on Linux x86 and x86_64. >> >> gdb/ChangeLog: >> >> 2015-12-03 Josh Stone >> Philippe Waroquiers >> >> * NEWS (Changes since GDB 7.10): Mention QCatchSyscalls and new >> GDBserver support for catch syscall. >> * remote.c (PACKET_QCatchSyscalls): New enum. >> (remote_set_syscall_catchpoint): New function. >> (remote_protocol_features): New element for QCatchSyscalls. >> (remote_parse_stop_reply): Parse syscall_entry/return stops. >> (init_remote_ops): Install remote_set_syscall_catchpoint. >> (_initialize_remote): Config QCatchSyscalls. >> * linux-nat.h (struct lwp_info) : Comment typo. >> >> gdb/doc/ChangeLog: >> >> 2015-12-03 Josh Stone >> Philippe Waroquiers >> >> * gdb.texinfo (Remote Configuration): List the QCatchSyscalls packet. >> (Stop Reply Packets): List the syscall entry and return stop reasons. >> (General Query Packets): Describe QCatchSyscalls, and add it to the >> table and detailed list of stub features. > > Any changes since v2 in the documentation parts that require a fresh > review? I made the changes you requested in v2 -- v3 just has some merge-resolution in NEWS. But Pedro has noted some more things to document for the next round.