From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-127879-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 41679 invoked by alias); 3 Dec 2015 14:41:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 41669 invoked by uid 89); 3 Dec 2015 14:41:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2
X-HELO: usplmg20.ericsson.net
Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 03 Dec 2015 14:41:56 +0000
Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87])	by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 5D.D1.06940.A8450665; Thu,  3 Dec 2015 15:41:15 +0100 (CET)
Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Thu, 3 Dec 2015 09:41:54 -0500
Subject: Re: [PATCH v4 3/6] Refactor arm_software_single_step to use regcache.
To: Yao Qi <qiyaoltc@gmail.com>
References: <1449062264-18565-1-git-send-email-antoine.tremblay@ericsson.com> <1449062264-18565-4-git-send-email-antoine.tremblay@ericsson.com> <86egf3u8py.fsf@gmail.com> <56603F64.6050906@ericsson.com> <861tb3tx7s.fsf@gmail.com>
CC: <gdb-patches@sourceware.org>
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
Message-ID: <566054B1.4060205@ericsson.com>
Date: Thu, 03 Dec 2015 14:41:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <861tb3tx7s.fsf@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-12/txt/msg00049.txt.bz2



On 12/03/2015 09:37 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> Unfortunately we do for the syscall_next_pc target dependent call.
>>
>> The reason I did not change syscall_next_pc for regcache is that this
>> would require the implementation of a syscall_next_pc that is not
>> using the frame unwinders and directly inspects the stack for multiple
>> targets.
>>
>> This would need to be done for arm,  mips, nios2, and tix6x.
>>
>> software_single_step would also have to be adapted for mips, nios2 and
>> tix6x for this new api.
>
> We don't need to touch targets other than arm.  syscall_next_pc is a
> function pointer in struct gdbarch_tdep in arm-tdep.h.
>

Oops indeed sorry my bad, I'll change it then.

> /* Target-dependent structure in gdbarch.  */
> struct gdbarch_tdep
> {
>    ...
>    /* Return the expected next PC if FRAME is stopped at a syscall
>       instruction.  */
>    CORE_ADDR (*syscall_next_pc) (struct frame_info *frame);
>    ...
> };
>
> we can change frame to regcache.
>
> The indentation looks odd in my mailer, if it is right to you, that is
> fine.  Maybe, my mailer doesn't show the code format correctly.
>

That happens all the time to me with thunderbird in a reply window...