From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115515 invoked by alias); 2 Dec 2015 13:36:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115506 invoked by uid 89); 2 Dec 2015 13:36:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 02 Dec 2015 13:36:50 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id A03DEC0CC649; Wed, 2 Dec 2015 13:36:49 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB2DamXA016034; Wed, 2 Dec 2015 08:36:48 -0500 Message-ID: <565EF3EF.4080009@redhat.com> Date: Wed, 02 Dec 2015 13:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v4 0/6] Support software single step and conditional breakpoints on ARM in GDBServer. References: <1449062264-18565-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1449062264-18565-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00032.txt.bz2 On 12/02/2015 01:17 PM, Antoine Tremblay wrote: > In this v4: > > Patches [1-5] of the v3 have been pushed in. > > A new patch 3 is now introduced to refactor arm_software_single_step to > use regcache instead of frame so that we can share the registry reading > function regcache_raw_read_unsigned between GDB and GDBServer. > > This allows the removal of the operation collect_register_unsigned from > the get_next_pcs context structure. > > Patch 1: is OK. > Patch 2: is OK. > Patch 3: New patch needs review. > Patch 4: Needs review. This was adapted based on the new patch 3. > Patch 5: is OK. > Patch 6: is OK. Is the syscall issue fixed in this version? Thanks, Pedro Alves