From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 742 invoked by alias); 27 Nov 2015 15:35:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 723 invoked by uid 89); 27 Nov 2015 15:35:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 27 Nov 2015 15:35:16 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 72.F9.32102.13878565; Fri, 27 Nov 2015 16:35:13 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Fri, 27 Nov 2015 10:35:14 -0500 Subject: Re: [PATCH v3 08/10] Support software single step on ARM in GDBServer. To: Yao Qi , References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-9-git-send-email-antoine.tremblay@ericsson.com> <86ziy1vsdr.fsf@gmail.com> <5657213B.30504@ericsson.com> <56572D68.90107@gmail.com> <56572E47.9030306@ericsson.com> <56585E8B.1030104@ericsson.com> <5658739E.4060605@gmail.com> From: Antoine Tremblay Message-ID: <56587831.2030909@ericsson.com> Date: Fri, 27 Nov 2015 15:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5658739E.4060605@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00593.txt.bz2 On 11/27/2015 10:15 AM, Yao Qi wrote: > On 27/11/15 13:45, Antoine Tremblay wrote: >> >> And I don't think it's good to have it in 2 calls, so I will have the >> same collect_register_unsigned_field... > > If so, let us keep collect_register_unsigned field. >> >> Thus this refactoring would not simplify the patch and IMHO would create >> some inconsistency why are we using regcache in some place for no >> apparent gain while all the rest uses frame. > > That is what I want to avoid... for the software single step routines > in two sides (GDB and GDBserver), I don't want to see that regcache is > used in one side while frame is used in the other side. regcache should > be used in both sides. > >> >> In light of this, I plan to keep it as is unless there's an objection ? > > Sorry, I don't like the patch as is. I plan to change gdbarch method > software_single_step to something like this, > > F:VEC (CORE_ADDR) *:software_single_step:struct regcache *regcache:regcache > > it returns a set of address on which GDB can insert software single step > breakpoint. > Alright as long as it's understood that the fields will stay, I'll do it like this. Thanks, Antoine