From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68446 invoked by alias); 27 Nov 2015 15:15:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68434 invoked by uid 89); 27 Nov 2015 15:15:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 27 Nov 2015 15:15:47 +0000 Received: by pacdm15 with SMTP id dm15so117389728pac.3 for ; Fri, 27 Nov 2015 07:15:45 -0800 (PST) X-Received: by 10.98.16.219 with SMTP id 88mr49171861pfq.154.1448637345872; Fri, 27 Nov 2015 07:15:45 -0800 (PST) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id fm1sm28979339pab.6.2015.11.27.07.15.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Nov 2015 07:15:45 -0800 (PST) Subject: Re: [PATCH v3 08/10] Support software single step on ARM in GDBServer. To: Antoine Tremblay , gdb-patches@sourceware.org References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-9-git-send-email-antoine.tremblay@ericsson.com> <86ziy1vsdr.fsf@gmail.com> <5657213B.30504@ericsson.com> <56572D68.90107@gmail.com> <56572E47.9030306@ericsson.com> <56585E8B.1030104@ericsson.com> From: Yao Qi Message-ID: <5658739E.4060605@gmail.com> Date: Fri, 27 Nov 2015 15:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56585E8B.1030104@ericsson.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00591.txt.bz2 On 27/11/15 13:45, Antoine Tremblay wrote: > > And I don't think it's good to have it in 2 calls, so I will have the > same collect_register_unsigned_field... If so, let us keep collect_register_unsigned field. > > Thus this refactoring would not simplify the patch and IMHO would create > some inconsistency why are we using regcache in some place for no > apparent gain while all the rest uses frame. That is what I want to avoid... for the software single step routines in two sides (GDB and GDBserver), I don't want to see that regcache is used in one side while frame is used in the other side. regcache should be used in both sides. > > In light of this, I plan to keep it as is unless there's an objection ? Sorry, I don't like the patch as is. I plan to change gdbarch method software_single_step to something like this, F:VEC (CORE_ADDR) *:software_single_step:struct regcache *regcache:regcache it returns a set of address on which GDB can insert software single step breakpoint. -- Yao (齐尧)