From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41261 invoked by alias); 27 Nov 2015 13:45:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41242 invoked by uid 89); 27 Nov 2015 13:45:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 27 Nov 2015 13:45:49 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id AC.E2.32102.A8E58565; Fri, 27 Nov 2015 14:45:46 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.248.2; Fri, 27 Nov 2015 08:45:47 -0500 Subject: Re: [PATCH v3 08/10] Support software single step on ARM in GDBServer. To: References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-9-git-send-email-antoine.tremblay@ericsson.com> <86ziy1vsdr.fsf@gmail.com> <5657213B.30504@ericsson.com> <56572D68.90107@gmail.com> <56572E47.9030306@ericsson.com> From: Antoine Tremblay Message-ID: <56585E8B.1030104@ericsson.com> Date: Fri, 27 Nov 2015 13:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56572E47.9030306@ericsson.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00583.txt.bz2 On 11/26/2015 11:07 AM, Antoine Tremblay wrote: > > > On 11/26/2015 11:03 AM, Yao Qi wrote: >> >> >> On 26/11/15 15:11, Antoine Tremblay wrote: >>> This is the same link as the previous one... >>> >> >> Oops, sorry, https://sourceware.org/ml/gdb-patches/2007-06/msg00087.html >> > Thanks > >> >>> IMO, it is >>>> better to use regcache than frame. We have two options, >>>> >>>> #1, switch from frame apis to regcache apis to access registers in >>>> arm >>>> software single step. We can get regcache by get_current_regcache >>>> (). >> About this one, as we thought it would simplify the collect_register_unsigned field. It's unfortunate but it won't because GDB's collect_registers_unsigned reads the registers and then calls extract_register_unsigned (in the same call). This function uses bfd enums for byte ordering and I can't use that in GDBServer as discussed previously. So I will not be able to directly share GDB's collect_registers_unsigned, thus either collect_register_unsigned will be replaced by 2 calls, one shared that fetches the register, and then a call that extracts the integer as a different operation on GDB and GDBserver or I will end up with the same collect_register_unsigned field only it will be using regcache on GDBServer's side now. And I don't think it's good to have it in 2 calls, so I will have the same collect_register_unsigned_field... Thus this refactoring would not simplify the patch and IMHO would create some inconsistency why are we using regcache in some place for no apparent gain while all the rest uses frame. In light of this, I plan to keep it as is unless there's an objection ? Regards, Antoine