From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10900 invoked by alias); 26 Nov 2015 16:57:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10866 invoked by uid 89); 26 Nov 2015 16:57:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Nov 2015 16:57:24 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 815ABA1423; Thu, 26 Nov 2015 16:57:23 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAQGvMph027753; Thu, 26 Nov 2015 11:57:22 -0500 Message-ID: <565739F1.2010005@redhat.com> Date: Thu, 26 Nov 2015 16:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/3] Add test for thread names References: <1448488138-2360-1-git-send-email-simon.marchi@ericsson.com> <1448488138-2360-4-git-send-email-simon.marchi@ericsson.com> <5656F0C2.4070203@redhat.com> <56572C7F.3030101@ericsson.com> In-Reply-To: <56572C7F.3030101@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00574.txt.bz2 On 11/26/2015 03:59 PM, Simon Marchi wrote: > I modified names.c significantly, so could you give it another quick look? Looks great, thanks. > + /* Make sure that NAMES contains NUM_THREADS elements. */ > + assert (sizeof (names) == sizeof (names[0]) * NUM_THREADS); BTW, the standard pattern would be: assert (sizeof (names) / sizeof (names[0]) == NUM_THREADS); which at least my brain processes immediately like ARRAY_SIZE, while with the * form, I have to stop and think. Thanks, Pedro Alves