From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107940 invoked by alias); 26 Nov 2015 16:07:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107925 invoked by uid 89); 26 Nov 2015 16:07:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Nov 2015 16:07:38 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id F7.4F.32102.74E27565; Thu, 26 Nov 2015 17:07:35 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.248.2; Thu, 26 Nov 2015 11:07:36 -0500 Subject: Re: [PATCH v3 08/10] Support software single step on ARM in GDBServer. To: Yao Qi References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-9-git-send-email-antoine.tremblay@ericsson.com> <86ziy1vsdr.fsf@gmail.com> <5657213B.30504@ericsson.com> <56572D68.90107@gmail.com> CC: From: Antoine Tremblay Message-ID: <56572E47.9030306@ericsson.com> Date: Thu, 26 Nov 2015 16:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56572D68.90107@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00568.txt.bz2 On 11/26/2015 11:03 AM, Yao Qi wrote: > > > On 26/11/15 15:11, Antoine Tremblay wrote: >> This is the same link as the previous one... >> > > Oops, sorry, https://sourceware.org/ml/gdb-patches/2007-06/msg00087.html > Thanks > >> IMO, it is >>> better to use regcache than frame. We have two options, >>> >>> #1, switch from frame apis to regcache apis to access registers in arm >>> software single step. We can get regcache by get_current_regcache >>> (). >>> #2, change argument of gdbarch method software_single_step from frame >>> to regcache, which means all its implementations need update, and >>> switch to regcache apis to access registers. >>> >>> #2 is the right way to go in long term, and we really need to improve >>> software_single_step. Let me what do you think. >>> >> >> Looking at the impacts of #2, I do not feel comfortable including these >> changes in this patch set. I feel they would require a patch set of >> their own. >> >> However #1 seems like something possible I would start by this option if >> that's fine with you ? > > Yes. > >> >> Also, I can still do the refactoring before this patch but it will >> require more work since I'll have to diff the functions moved etc.. do >> you feel it's required to do so or the refactoring could be done after >> this patch ? > > I prefer doing the refactor first, and separately, because after this > refactor, your patch #8 will be simplified a lot. In this series, we > want to share the code on arm software single step, however, registers > are accessed through frame in GDB side, while through regcache in > GDBserver. In order to share code, we should unify them as much as we > can, that is, access registers through regcache as well in GDB side. > Then, we can move the code from arm-tdep.c to arch/ directory, to > support software single step in GDBserver. > Yes ok I'll do it this way then.