From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58530 invoked by alias); 26 Nov 2015 15:46:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58518 invoked by uid 89); 26 Nov 2015 15:46:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Nov 2015 15:46:15 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 49.8D.32102.44927565; Thu, 26 Nov 2015 16:46:12 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.248.2; Thu, 26 Nov 2015 10:46:13 -0500 Subject: Re: [PATCH v2 1/3] Constify thread name return path To: Pedro Alves , References: <1448488138-2360-1-git-send-email-simon.marchi@ericsson.com> <1448488138-2360-2-git-send-email-simon.marchi@ericsson.com> <5656EB38.6080601@redhat.com> From: Simon Marchi Message-ID: <56572945.3000309@ericsson.com> Date: Thu, 26 Nov 2015 15:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5656EB38.6080601@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00563.txt.bz2 On 15-11-26 06:21 AM, Pedro Alves wrote: > On 11/25/2015 09:48 PM, Simon Marchi wrote: >> Since this code path returns a string owned by the target (we don't know how >> it's allocated, could be a static read-only string), it's safer if we return >> a constant string. If, for some reasons, the caller wishes to modify the >> string, it should make itself a copy. >> >> gdb/ChangeLog: >> >> * linux-nat.c (linux_nat_thread_name): Constify return value. >> * target.h (struct target_ops) : Likewise. >> (target_thread_name): Likewise. >> * target.c (target_thread_name): Likewise. >> * target-delegates.c (debug_thread_name): Regenerate. >> * python/py-infthread.c (thpy_get_name): Constify local variables. >> * thread.c (print_thread_info): Likewise. >> (thread_find_command): Likewise. > > OK. > > Thanks, > Pedro Alves > Thanks, pushed.