From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35085 invoked by alias); 26 Nov 2015 15:34:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35071 invoked by uid 89); 26 Nov 2015 15:34:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Nov 2015 15:34:56 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id ED.CC.32102.C9627565; Thu, 26 Nov 2015 16:34:53 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Thu, 26 Nov 2015 10:34:53 -0500 Subject: Re: [PATCH v3 10/10] Enable conditional breakpoints for targets that support software single step in GDBServer. To: Yao Qi References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-11-git-send-email-antoine.tremblay@ericsson.com> <86d1uxxdkg.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <5657269D.6000809@ericsson.com> Date: Thu, 26 Nov 2015 15:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <86d1uxxdkg.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00562.txt.bz2 On 11/26/2015 05:25 AM, Yao Qi wrote: > Antoine Tremblay writes: > >> No regressions, tested on ubuntu 14.04 ARMv7 and x86. >> With gdbserver-{native,extended} / { -marm -mthumb } > > There should be more PASS in the test result, what are they? > (gdb) PASS: gdb.base/cond-eval-mode.exp: set breakpoint condition-evaluation target (gdb) PASS: gdb.base/cond-eval-mode.exp: probe for target remote (gdb) PASS: gdb.base/cond-eval-mode.exp: set remote conditional-breakpoints-packet off (gdb) PASS: gdb.base/cond-eval-mode.exp: set breakpoint condition-evaluation target, with support disabled (gdb) PASS: gdb.base/cond-eval-mode.exp: set remote conditional-breakpoints-packet on (gdb) PASS: gdb.base/cond-eval-mode.exp: restore set breakpoint condition-evaluation target (gdb) PASS: gdb.base/cond-eval-mode.exp: break: break foo (gdb) PASS: gdb.base/cond-eval-mode.exp: break: condition $bpnum cond_global==0 (gdb) PASS: gdb.base/cond-eval-mode.exp: break: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: break: break foo (gdb) PASS: gdb.base/cond-eval-mode.exp: break: condition $bpnum cond_global==1 (gdb) PASS: gdb.base/cond-eval-mode.exp: break: b bar (gdb) PASS: gdb.base/cond-eval-mode.exp: break: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: hbreak foo (gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: condition $bpnum cond_global==0 (gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: hbreak foo (gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: condition $bpnum cond_global==1 (gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: b bar (gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: watch: watch global (gdb) PASS: gdb.base/cond-eval-mode.exp: watch: condition $bpnum cond_global==0 (gdb) PASS: gdb.base/cond-eval-mode.exp: watch: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: watch: watch global (gdb) PASS: gdb.base/cond-eval-mode.exp: watch: condition $bpnum cond_global==1 (gdb) PASS: gdb.base/cond-eval-mode.exp: watch: b bar (gdb) PASS: gdb.base/cond-eval-mode.exp: watch: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: rwatch global (gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: condition $bpnum cond_global==0 (gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: rwatch global (gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: condition $bpnum cond_global==1 (gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: b bar (gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: awatch global (gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: condition $bpnum cond_global==0 (gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: continue (gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: awatch global (gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: condition $bpnum cond_global==1 (gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: b bar (gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: continue Should these be part of the commit log ? as : New tests passing : PASS: gdb.base/cond-eval-mode.exp: set breakpoint condition-evaluation target and related... Maybe? Thanks, Antoine Tremblay