From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120676 invoked by alias); 26 Nov 2015 13:56:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120640 invoked by uid 89); 26 Nov 2015 13:56:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Nov 2015 13:56:48 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 9E.E6.32102.D9F07565; Thu, 26 Nov 2015 14:56:45 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.248.2; Thu, 26 Nov 2015 08:56:46 -0500 Subject: Re: [PATCH v3 07/10] Share some ARM target dependant code from GDB with GDBServer. To: Yao Qi References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-8-git-send-email-antoine.tremblay@ericsson.com> <864mg9xcyo.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <56570F9D.2070802@ericsson.com> Date: Thu, 26 Nov 2015 13:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <864mg9xcyo.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00560.txt.bz2 On 11/26/2015 05:38 AM, Yao Qi wrote: > Antoine Tremblay writes: > >> +/* See arm.h. */ >> + >> +int >> +condition_true (unsigned long cond, unsigned long status_reg) > > We need "arm_" prefix for this function. Otherwise, patch is OK. > Ok in fact I guess I should add this prefix to bitcount too.