From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60469 invoked by alias); 26 Nov 2015 13:50:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60456 invoked by uid 89); 26 Nov 2015 13:50:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Nov 2015 13:50:34 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 2D.76.32102.72E07565; Thu, 26 Nov 2015 14:50:31 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.248.2; Thu, 26 Nov 2015 08:50:31 -0500 Subject: Re: [PATCH v3 06/10] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer. To: Pedro Alves , References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-7-git-send-email-antoine.tremblay@ericsson.com> <5656E3FF.90909@redhat.com> From: Antoine Tremblay Message-ID: <56570E27.6010605@ericsson.com> Date: Thu, 26 Nov 2015 13:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5656E3FF.90909@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00559.txt.bz2 On 11/26/2015 05:50 AM, Pedro Alves wrote: > On 11/23/2015 02:12 PM, Antoine Tremblay wrote: >> In this v3: >> >> * Changed get_next_pcs signature. >> * Remove common/get-next-pcs.h file. >> * CORE_ADDR is now in linux-low.h temporarely. >> >> --- >> >> This patch in preparation for software single step support on ARM. It refactors >> breakpoint_reinsert_addr into get_next_pcs so that multiple location can be >> returned. >> >> When software single stepping there can be multiple possible next addresses >> because we're stepping over a conditional branch instruction for example. >> >> The operation get_next_pcs handles that by returning a vector of all the >> possible next addresses. >> >> Software breakpoints are installed at each location returned. >> > > > Thanks for doing this. This interface does look cleaner to me, and a > more direct mapping C++ (so easier to clean up in the future). > Indeed thanks for the idea! >> >> +/* Install breakpoints for software single stepping. */ >> + >> +static void >> +install_software_single_step_breakpoints (struct lwp_info *lwp) >> +{ >> + int i; >> + CORE_ADDR pc; >> + struct regcache *regcache = get_thread_regcache (current_thread, 1); >> + VEC (CORE_ADDR) *next_pcs = NULL; > > I think this should be freed with a cleanup. > >> + >> + pc = get_pc (lwp); >> + next_pcs = (*the_low_target.get_next_pcs) (pc, regcache); >> + >> + for (i = 0; VEC_iterate (CORE_ADDR, next_pcs, i, pc); ++i) >> + { >> + set_reinsert_breakpoint (pc); >> + } > > Single-line statements don't get braces. > Done, learning the style :) Thank you, Antoine