From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84919 invoked by alias); 26 Nov 2015 11:45:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84903 invoked by uid 89); 26 Nov 2015 11:45:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Nov 2015 11:45:09 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 07752C0D223C; Thu, 26 Nov 2015 11:45:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAQBj6n4016500; Thu, 26 Nov 2015 06:45:07 -0500 Message-ID: <5656F0C2.4070203@redhat.com> Date: Thu, 26 Nov 2015 11:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/3] Add test for thread names References: <1448488138-2360-1-git-send-email-simon.marchi@ericsson.com> <1448488138-2360-4-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1448488138-2360-4-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00548.txt.bz2 On 11/25/2015 09:48 PM, Simon Marchi wrote: > +int > +main (int argc, char **argv) > +{ > + pthread_t threads[NUM_THREADS]; > + struct thread_data args[NUM_THREADS]; > + pthread_barrier_t barrier; > + int i; > + const char *names[] = { "carrot", "potato", "celery" }; Add an alarm call so the process doesn't run forever if something goes wrong and it gets detached / reparented to init. > + > + /* Make sure that NAMES contains NUM_THREADS elements. */ > + assert (sizeof (names) == sizeof(names[0]) * NUM_THREADS); > + > + assert (0 == pthread_barrier_init (&barrier, NULL, NUM_THREADS + 1)); There should be no side-effects in assert calls: res = pthread_barrier_init (&barrier, NULL, NUM_THREADS + 1)); assert (res == 0); > + > + pthread_setname_np (pthread_self (), "main"); > + > + for (i = 0; i < NUM_THREADS; i++) > + { > + struct thread_data *arg = &args[i]; > + > + arg->name = names[i]; > + arg->barrier = &barrier; > + > + assert (0 == pthread_create (&threads[i], NULL, thread_func, arg)); Ditto. > + } > + > + pthread_barrier_wait (&barrier); > + > + all_threads_ready (); > + > + return 0; > +} OK with above fixed. > +set expected_thread_list "\\* 1 .*\"main\" all_threads_ready.*\n" > +append expected_thread_list " 2 .*\"carrot\".*\n" > +append expected_thread_list " 3 .*\"potato\".*\n" > +append expected_thread_list " 4 .*\"celery\".*" > + > +gdb_test "info threads" "$expected_thread_list" "list threads" Note you can do this with multi_line. E.g.: gdb_test "info threads" \ [multi_line \ "\\* 1 .*\"main\" all_threads_ready.*" \ " 2 .*\"carrot\".*" \ " 3 .*\"potato\".*" \ " 4 .*\"celery\".*"] \ "list threads" Thanks, Pedro Alves