From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107768 invoked by alias); 26 Nov 2015 10:50:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107739 invoked by uid 89); 26 Nov 2015 10:50:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Nov 2015 10:50:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 6EF02461C4; Thu, 26 Nov 2015 10:50:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAQAoeVi010332; Thu, 26 Nov 2015 05:50:40 -0500 Message-ID: <5656E3FF.90909@redhat.com> Date: Thu, 26 Nov 2015 10:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v3 06/10] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer. References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-7-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1448287968-12907-7-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00545.txt.bz2 On 11/23/2015 02:12 PM, Antoine Tremblay wrote: > In this v3: > > * Changed get_next_pcs signature. > * Remove common/get-next-pcs.h file. > * CORE_ADDR is now in linux-low.h temporarely. > > --- > > This patch in preparation for software single step support on ARM. It refactors > breakpoint_reinsert_addr into get_next_pcs so that multiple location can be > returned. > > When software single stepping there can be multiple possible next addresses > because we're stepping over a conditional branch instruction for example. > > The operation get_next_pcs handles that by returning a vector of all the > possible next addresses. > > Software breakpoints are installed at each location returned. > Thanks for doing this. This interface does look cleaner to me, and a more direct mapping C++ (so easier to clean up in the future). > > +/* Install breakpoints for software single stepping. */ > + > +static void > +install_software_single_step_breakpoints (struct lwp_info *lwp) > +{ > + int i; > + CORE_ADDR pc; > + struct regcache *regcache = get_thread_regcache (current_thread, 1); > + VEC (CORE_ADDR) *next_pcs = NULL; I think this should be freed with a cleanup. > + > + pc = get_pc (lwp); > + next_pcs = (*the_low_target.get_next_pcs) (pc, regcache); > + > + for (i = 0; VEC_iterate (CORE_ADDR, next_pcs, i, pc); ++i) > + { > + set_reinsert_breakpoint (pc); > + } Single-line statements don't get braces. Otherwise LGTM. Thanks, Pedro Alves