From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63052 invoked by alias); 23 Nov 2015 18:15:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62303 invoked by uid 89); 23 Nov 2015 18:15:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Nov 2015 18:15:16 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 6E53FC0A527E; Mon, 23 Nov 2015 18:15:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tANIFEhE029418; Mon, 23 Nov 2015 13:15:14 -0500 Message-ID: <565357B1.4070805@redhat.com> Date: Mon, 23 Nov 2015 18:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 03/18] attach + target always in non-stop mode: stop all threads References: <1444836486-25679-1-git-send-email-palves@redhat.com> <1444836486-25679-4-git-send-email-palves@redhat.com> <86r3ki0vzy.fsf@gmail.com> In-Reply-To: <86r3ki0vzy.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00491.txt.bz2 On 10/26/2015 10:22 AM, Yao Qi wrote: > Pedro Alves writes: > >> In addition, it's not defined whith thread manages to report the > > s/whith/which > >> initial attach stop, so always pick the lowest one (otherwise >> multi-attach.exp regresses). > > Shouldn't GDB pick the main thread rather than the lowest one? It actually ends up being the same, and bit more generic to go with lowest, because target_attach should always adds the main thread first. Otherwise, there's no such concept of "main" thread in the common code. "The thread with pid == lwpid" holds true for NTPL/Linux, but not everywhere, and even then the leader thread may have exited already. I'll update the comment. Thanks, Pedro Alves