From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41084 invoked by alias); 23 Nov 2015 15:41:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41074 invoked by uid 89); 23 Nov 2015 15:41:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Nov 2015 15:41:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A5C7B83F6A; Mon, 23 Nov 2015 15:41:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tANFf1EG011785; Mon, 23 Nov 2015 10:41:02 -0500 Message-ID: <5653338D.3010908@redhat.com> Date: Mon, 23 Nov 2015 15:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 10/18] Remote thread create/exit events References: <1444836486-25679-1-git-send-email-palves@redhat.com> <1444836486-25679-11-git-send-email-palves@redhat.com> <86eggh20rp.fsf@gmail.com> In-Reply-To: <86eggh20rp.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00479.txt.bz2 On 10/26/2015 01:54 PM, Yao Qi wrote: > Pedro Alves writes: > > Hi Pedro, > >> @@ -6417,6 +6425,11 @@ Packet: '%s'\n"), >> one used by the original program. */ >> skipregs = 1; >> } >> + else if (strprefix (p, p1, "create")) >> + { >> + event->ws.kind = TARGET_WAITKIND_THREAD_CREATED; >> + p = skip_to_semicolon (p1 + 1); >> + } >> else >> { >> ULONGEST pnum; > > Looks you add thread create/exit events on current stop notification. > I am wondering why don't we add a new notification for thread > create/exit. It should straightforward to add a new notification under > current remote notification infrastructure. Actually, TARGET_WAITKIND_THREAD_CREATED is really a stop, just like TARGET_WAITKIND_FORKED, etc. That is, when it is reported, the thread is stopped at its entry point. Thanks, Pedro Alves