From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-127634-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21615 invoked by alias); 20 Nov 2015 11:31:07 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 21447 invoked by uid 89); 20 Nov 2015 11:31:06 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Nov 2015 11:31:05 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (Postfix) with ESMTPS id BCD2AC0BFBD4;	Fri, 20 Nov 2015 11:31:03 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAKBV2WA000825;	Fri, 20 Nov 2015 06:31:03 -0500
Message-ID: <564F0476.4050700@redhat.com>
Date: Fri, 20 Nov 2015 11:31:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Markus Metzger <markus.t.metzger@intel.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH] btrace: diagnose "record btrace pt" without libipt
References: <1448011026-4192-1-git-send-email-markus.t.metzger@intel.com>
In-Reply-To: <1448011026-4192-1-git-send-email-markus.t.metzger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-11/txt/msg00419.txt.bz2

On 11/20/2015 09:17 AM, Markus Metzger wrote:

> support for the requested branch tracing format, also check whether GDB
> supports. it.

( Nit: spurious '.'. )

> 
> 2015-11-20  Markus Metzger  <markus.t.metzger@intel.com>
> 
> gdb/
> 	* btrace.c (btrace_enable): Check whether HAVE_LIBIPT is defined.
> 
> testsuite/
> 	* gdb.exp (skip_btrace_pt_tests): Check for a "GDB does not support"
> 	error.

LGTM.

Thanks,
Pedro Alves