Re: RFA: AArch64 sim

[Nick Clifton <nickc@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Hi Mike,

   Thanks for review.

> i've posted a patch to clean up the others.  you should trim it from this
> one in the meantime.

OK - I have done that.

> i'm not seeing how this is cleaner.  when you call sim_engine_halt, the
> code stops at that point.  there is no returning/etc... afterwards.
>
> plus, when i look at some of these funcs, they only ever return READY.
> which leads to a lot of return code paths that are pointless.

Okey dokey - I have now refactored the code, removing the StatusCode 
return value from lots of functions, and calling sim_engine_halt from 
any location where a problem or break is encountered.

> you should scan the files and trim trailing whitespace while you're at it.
> sed -i -r 's:[[:space:]]+$::' *.[ch]

Also done.

Is this version OK ?

Cheers
   Nick



[-- Attachment #2: aarch64.sim.patch.4.xz --]
[-- Type: application/x-xz, Size: 50424 bytes --]