From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97541 invoked by alias); 19 Nov 2015 13:43:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97528 invoked by uid 89); 19 Nov 2015 13:42:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 19 Nov 2015 13:42:59 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id BB.1A.26730.BA36D465; Thu, 19 Nov 2015 06:52:44 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Thu, 19 Nov 2015 08:42:56 -0500 Subject: Re: [PATCH 0/4] [C++, AArch64] Fix warnings and errors To: Yao Qi , References: <1447938062-29624-1-git-send-email-yao.qi@linaro.org> From: Simon Marchi Message-ID: <564DD1E0.1080709@ericsson.com> Date: Thu, 19 Nov 2015 13:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447938062-29624-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00393.txt.bz2 On 15-11-19 08:00 AM, Yao Qi wrote: > This patch set fixes warnings and errors when I build GDB and GDBserver > in C++ mode for native aarch64-linux. There is still one error fixed > by Simon's patch, > > [PATCH] Fix length calculation in aarch64_linux_set_debug_regs > https://sourceware.org/ml/gdb-patches/2015-11/msg00010.html > > I think Simon's patch should go in too. Each of them is obvious to > me. I'll push them in soon. > > *** BLURB HERE *** > > Yao Qi (4): > Cast void * to struct user_pt_regs * > Cast void * to user_fpsimd_state *. > Define enum out of the scope of struct > Change argument opcode type from enum aarch64_opcodes to uint32_t > > gdb/gdbserver/linux-aarch64-low.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) > The series looks good to me. Thanks!